kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PD: [skip ci] Fix several clazy issues:

Browse Source 
* Maybe you meant to call base method instead [-Wclazy-skipped-base-method]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* Mixing iterators with const_iterators [-Wclazy-strict-iterators]
* Unused QByteArray [-Wclazy-unused-non-trivial-variable]
* C++11 range-loop might detach Qt container (QList) [-Wclazy-range-loop-detach]
This commit is contained in:
wmayer
2022-07-25 13:40:19 +02:00
parent 50ef527ded
commit a93082bc06
19 changed files with 83 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Mod/PartDesign/Gui/TaskShapeBinder.cpp
View File

@@ -99,7 +99,7 @@ void TaskShapeBinder::updateUI()
connect(ui->baseEdit, &QLineEdit::textChanged,
this, &TaskShapeBinder::supportChanged);
for (auto sub : subs)
for (const auto& sub : subs)
ui->listWidgetReferences->addItem(QString::fromStdString(sub));
if (obj) {
@@ -222,7 +222,7 @@ void TaskShapeBinder::removeFromListWidget(QListWidget* widget, QString itemstr)
{
QList<QListWidgetItem*> items = widget->findItems(itemstr, Qt::MatchExactly);
if (!items.empty()) {
for (QList<QListWidgetItem*>::const_iterator i = items.begin(); i != items.end(); i++) {
for (QList<QListWidgetItem*>::const_iterator i = items.cbegin(); i != items.cend(); i++) {
QListWidgetItem* it = widget->takeItem(widget->row(*i));
delete it;
}