kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

TechDraw: add transactions to multiple commands (#22795)

Browse Source 
* TechDraw: add transactions to multiple commands

* Feed each 'Create Dimension' option to the translation macro

* Call fixSceneDependencies when re-adding dimensions so that it shows up at the right place
This commit is contained in:
theo-vt
2025-08-18 11:46:15 -04:00
committed by GitHub
parent d8168d33f3
commit a94dc1463d
8 changed files with 49 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/Mod/TechDraw/Gui/CommandCreateDims.cpp
View File

@@ -2086,11 +2086,20 @@ bool CmdTechDrawHorizontalExtentDimension::isActive()
void execExtent(Gui::Command* cmd, const std::string& dimType)
{
const char* commandString = nullptr;
if (dimType == "DistanceX") {
commandString = QT_TRANSLATE_NOOP("Command", "Create Dimension DistanceX");
} else if (dimType == "DistanceY") {
commandString = QT_TRANSLATE_NOOP("Command", "Create Dimension DistanceY");
}
Gui::Command::openCommand(QT_TRANSLATE_NOOP("Command", commandString));
bool result = _checkDrawViewPart(cmd);
if (!result) {
QMessageBox::warning(Gui::getMainWindow(),
QObject::tr("Incorrect selection"),
QObject::tr("No view of a part in selection."));
Gui::Command::abortCommand();
return;
}
ReferenceVector references2d;
@@ -2106,6 +2115,7 @@ void execExtent(Gui::Command* cmd, const std::string& dimType)
QMessageBox::warning(Gui::getMainWindow(),
QObject::tr("Incorrect selection"),
QObject::tr("Selection contains both 2D and 3D geometry"));
Gui::Command::abortCommand();
return;
}
}
@@ -2129,8 +2139,9 @@ void execExtent(Gui::Command* cmd, const std::string& dimType)
references2d, acceptableGeometry, minimumCounts, acceptableDimensionGeometrys);
if (geometryRefs2d == DimensionGeometry::isInvalid) {
QMessageBox::warning(Gui::getMainWindow(),
QObject::tr("Incorrect selection"),
QObject::tr("Incorrect Selection"),
QObject::tr("Cannot make 2D extent dimension from selection"));
Gui::Command::abortCommand();
return;
}
@@ -2146,6 +2157,7 @@ void execExtent(Gui::Command* cmd, const std::string& dimType)
QMessageBox::warning(Gui::getMainWindow(),
QObject::tr("Incorrect Selection"),
QObject::tr("Cannot make 3D extent dimension from selection"));
Gui::Command::abortCommand();
return;
}
}
@@ -2156,6 +2168,7 @@ void execExtent(Gui::Command* cmd, const std::string& dimType)
else {
DrawDimHelper::makeExtentDim3d(partFeat, dimType, references3d);
}
Gui::Command::commitCommand();
}
//===========================================================================