From aa3fde2dae318cd2da30247ce5d10e504530c46d Mon Sep 17 00:00:00 2001 From: wmayer Date: Sun, 19 Jul 2020 13:40:06 +0200 Subject: [PATCH] Coverity: Big parameter passed by value --- src/App/Expression.cpp | 2 +- src/App/ExpressionParser.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/App/Expression.cpp b/src/App/Expression.cpp index bb3568e002..9c1bc60986 100644 --- a/src/App/Expression.cpp +++ b/src/App/Expression.cpp @@ -2467,7 +2467,7 @@ void FunctionExpression::_visit(ExpressionVisitor &v) TYPESYSTEM_SOURCE(App::VariableExpression, App::UnitExpression) -VariableExpression::VariableExpression(const DocumentObject *_owner, ObjectIdentifier _var) +VariableExpression::VariableExpression(const DocumentObject *_owner, const ObjectIdentifier& _var) : UnitExpression(_owner) , var(_var) { diff --git a/src/App/ExpressionParser.h b/src/App/ExpressionParser.h index f5b9545708..cbfb369034 100644 --- a/src/App/ExpressionParser.h +++ b/src/App/ExpressionParser.h @@ -321,7 +321,7 @@ protected: class AppExport VariableExpression : public UnitExpression { TYPESYSTEM_HEADER_WITH_OVERRIDE(); public: - VariableExpression(const App::DocumentObject *_owner = 0, ObjectIdentifier _var = ObjectIdentifier()); + VariableExpression(const App::DocumentObject *_owner = 0, const ObjectIdentifier& _var = ObjectIdentifier()); ~VariableExpression();