From ab7153b97f618e4cc2b362d28763c0097c05cac2 Mon Sep 17 00:00:00 2001 From: forbes Date: Sun, 1 Feb 2026 21:10:19 -0600 Subject: [PATCH] fix(solver): correct Newton-Raphson convergence check in OndselSolver The isConvergedToNumericalLimit() method compared dxNorms->at(iterNo) to itself instead of the previous iteration (iterNo - 1). This meant the solver could never detect convergence improvement, causing it to exhaust iterations on assemblies with many constraints, producing 'iterNo > iterMax' exceptions and 'grounded object moved' warnings. Also updates silo submodule pointer. --- mods/silo | 2 +- src/3rdParty/OndselSolver | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mods/silo b/mods/silo index 3a67d2082b..17a10ab1b6 160000 --- a/mods/silo +++ b/mods/silo @@ -1 +1 @@ -Subproject commit 3a67d2082b93173195e073ffc974c22e3db6a370 +Subproject commit 17a10ab1b68d13227d2b90e92163353f68e7fdc1 diff --git a/src/3rdParty/OndselSolver b/src/3rdParty/OndselSolver index 30e9b64e8b..e32c9cd793 160000 --- a/src/3rdParty/OndselSolver +++ b/src/3rdParty/OndselSolver @@ -1 +1 @@ -Subproject commit 30e9b64e8bf881d438d4b88834f9ba3674865418 +Subproject commit e32c9cd7934c62df3ea47899bf5be3a37797384d