kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Use QString's multi-arg overload to save memory allocations. [-Wclazy-qstring-arg] Thanks Clazy!

Browse Source
This commit is contained in:
Mateusz Skowroński
2019-01-30 19:43:13 +01:00
committed by wmayer
parent f98e930185
commit ac508516da
36 changed files with 177 additions and 192 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Gui/FileDialog.cpp
View File

@@ -115,7 +115,7 @@ void FileDialog::accept()
// #0001928: do not add a suffix if a file with suffix is entered
// #0002209: make sure that the entered suffix is part of one of the filters
if (!ext.isEmpty() && (suffix.isEmpty() || !hasSuffix(suffix))) {
file = QString::fromLatin1("%1.%2").arg(file).arg(ext);
file = QString::fromLatin1("%1.%2").arg(file, ext);
// That's the built-in line edit
QLineEdit* fileNameEdit = this->findChild<QLineEdit*>(QString::fromLatin1("fileNameEdit"));
if (fileNameEdit)
@@ -525,7 +525,7 @@ void FileOptionsDialog::accept()
if (ext.isEmpty())
setDefaultSuffix(suf);
else if (ext.toLower() != suf.toLower()) {
fn = QString::fromLatin1("%1.%2").arg(fn).arg(suf);
fn = QString::fromLatin1("%1.%2").arg(fn, suf);
selectFile(fn);
// That's the built-in line edit (fixes Debian bug #811200)
QLineEdit* fileNameEdit = this->findChild<QLineEdit*>(QString::fromLatin1("fileNameEdit"));
@@ -823,7 +823,7 @@ SelectModule::SelectModule (const QString& type, const SelectModule::Dict& types
module = module.left(pos);
}
button->setText(QString::fromLatin1("%1 (%2)").arg(filter).arg(module));
button->setText(QString::fromLatin1("%1 (%2)").arg(filter, module));
button->setObjectName(it.value());
gridLayout1->addWidget(button, index, 0, 1, 1);
group->addButton(button, index);