From acee460dd348d3ed4b5e32eb778d8b7738517803 Mon Sep 17 00:00:00 2001 From: Alfredo Monclus Date: Mon, 3 Mar 2025 10:45:22 -0300 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Benjamin Bræstrup Sayoc --- src/Gui/QSint/actionpanel/actionlabel.cpp | 4 ++-- src/Gui/QSint/actionpanel/actionpanelscheme.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Gui/QSint/actionpanel/actionlabel.cpp b/src/Gui/QSint/actionpanel/actionlabel.cpp index 3a548e0403..35619027d0 100644 --- a/src/Gui/QSint/actionpanel/actionlabel.cpp +++ b/src/Gui/QSint/actionpanel/actionlabel.cpp @@ -43,9 +43,9 @@ QSize ActionLabel::sizeHint() const QStyleOptionToolButton opt; initStyleOption(&opt); - QString s = text().isEmpty() ? QString::fromLatin1("XXXX") : text(); + QString s = text().isEmpty() ? QStringLiteral("XXXX") : text(); QSize textSize = fontMetrics().size(Qt::TextShowMnemonic, s); - const int padding = 10; + constexpr int padding = 10; int width = textSize.width(); if (!icon().isNull()) { diff --git a/src/Gui/QSint/actionpanel/actionpanelscheme.cpp b/src/Gui/QSint/actionpanel/actionpanelscheme.cpp index 6eecbbb9af..d250f9a0b5 100644 --- a/src/Gui/QSint/actionpanel/actionpanelscheme.cpp +++ b/src/Gui/QSint/actionpanel/actionpanelscheme.cpp @@ -12,7 +12,7 @@ namespace QSint { -const QString ActionPanelScheme::minimumStyle = QString::fromLatin1( +constexpr QString ActionPanelScheme::minimumStyle = QStringLiteral( "QSint--ActionGroup QFrame[class='header'] {" "border: none;" "}" @@ -49,7 +49,7 @@ QString ActionPanelScheme::systemStyle(const QPalette& p) replacements["headerBackground"] = headerBackground.name(); replacements["groupBackground"] = groupBackground.name();; - QString style = QString::fromLatin1( + QString style = QStringLiteral( "QSint--ActionGroup QFrame[class='header'] {" "background-color: {headerBackground};" "}"