kindred/create
1
1
Fork 0
Code Issues 31 Pull Requests 1 Actions 5 Packages Projects 9 Releases 2 Wiki Activity

Gui: Use auto and range-based for (#7481)

Browse Source 
* On lines where the variable type is obvious from inspection, avoid repeating the type using auto. 
* When possible use a ranged for loop instead of begin() and end() iterators
This commit is contained in:
berniev
2022-09-15 04:25:13 +10:00
committed by GitHub
parent f7c84dfd09
commit ae53c9b0a4
175 changed files with 2051 additions and 2057 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Gui/ViewProviderPythonFeature.cpp
View File

@@ -118,8 +118,8 @@ QIcon ViewProviderPythonFeatureImp::getIcon() const
QList<QByteArray> lines = ary.split('\n');
QByteArray buffer;
buffer.reserve(ary.size()+lines.size());
for (QList<QByteArray>::iterator it = lines.begin(); it != lines.end(); ++it) {
QByteArray trim = it->trimmed();
for (const auto & line : lines) {
QByteArray trim = line.trimmed();
if (!trim.isEmpty()) {
buffer.append(trim);
buffer.append('\n');
@@ -278,7 +278,7 @@ bool ViewProviderPythonFeatureImp::getDetail(const char* name, SoDetail *&det) c
Py::Object pydet(Base::pyCall(py_getDetail.ptr(),args.ptr()));
void* ptr = nullptr;
Base::Interpreter().convertSWIGPointerObj("pivy.coin", "SoDetail *", pydet.ptr(), &ptr, 0);
SoDetail* detail = static_cast<SoDetail*>(ptr);
auto detail = static_cast<SoDetail*>(ptr);
det = detail ? detail->copy() : nullptr;
return true;
}
@@ -319,7 +319,7 @@ ViewProviderPythonFeatureImp::ValueT ViewProviderPythonFeatureImp::getDetailPath
return Accepted;
void* ptr = nullptr;
Base::Interpreter().convertSWIGPointerObj("pivy.coin", "SoDetail *", pyDet.ptr(), &ptr, 0);
SoDetail* detail = static_cast<SoDetail*>(ptr);
auto detail = static_cast<SoDetail*>(ptr);
det = detail ? detail->copy() : nullptr;
if(det)
return Accepted;
@@ -668,8 +668,8 @@ ViewProviderPythonFeatureImp::onDelete(const std::vector<std::string> & sub)
try {
Py::Tuple seq(sub.size());
int index=0;
for (std::vector<std::string>::const_iterator it = sub.begin(); it != sub.end(); ++it) {
seq.setItem(index++, Py::String(*it));
for (const auto & it : sub) {
seq.setItem(index++, Py::String(it));
}
if (has__object__) {