PR review suggestions and fixes

This commit is contained in:
sliptonic
2020-12-01 09:43:45 -06:00
parent 3d822cf269
commit af153643f2
3 changed files with 6 additions and 6 deletions

View File

@@ -181,7 +181,7 @@ class ToolBitGuiFactory(PathToolBit.ToolBitFactory):
FreeCAD.ActiveDocument.commitTransaction()
return tool
def isValidFile(filename):
def isValidFileName(filename):
print(filename)
try:
with open(filename, "w") as tempfile:
@@ -198,7 +198,7 @@ def GetNewToolFile(parent=None):
PathPreferences.lastPathToolBit(),
'*.fctb')
if foo and foo[0]:
if not isValidFile(foo[0]):
if not isValidFileName(foo[0]):
msgBox = QtGui.QMessageBox()
msg = translate("Path", "Invalid Filename", None)
msgBox.setText(msg)

View File

@@ -389,9 +389,9 @@ class ToolBitLibrary(object):
return True
qm = PySide.QtGui.QMessageBox
ret = qm.question(None,'', "Please set up Toolbit Working Directory", qm.Ok | qm.Cancel)
ret = qm.question(None,'', "Toolbit working directory not set up. Do that now?", qm.Yes | qm.No)
if ret == qm.Cancel:
if ret == qm.No:
return False
msg = translate("Path", "Choose a writable location for your toolbits", None)