kindred/create
1
1
Fork 0
Code Issues 53 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Coverity issues:

Browse Source 
129202: replace dynamic_cast with static_cast
129421, 129422: fix Py_Return macro
128928: Unchecked return value
129488, 129490: uninitialized scalar variable
129567, 129661: uninitialized scalar field
129665: uninitialized pointer field
This commit is contained in:
wmayer
2016-08-15 21:28:41 +02:00
parent dde8c3f4c1
commit af4ef2fa7f
7 changed files with 34 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/App/ColorModel.cpp
View File

@@ -75,19 +75,24 @@ ColorField::ColorField (void)
}
ColorField::ColorField (const ColorModel &rclModel, float fMin, float fMax, unsigned short usCt)
: _clModel(ColorModelTria())
: _clModel(ColorModelTria())
{
set(rclModel, fMin, fMax, usCt);
}
ColorField::~ColorField ()
{
}
}
ColorField::ColorField (const ColorField &rclCF)
: _clModel(ColorModelTria())
: _clModel(rclCF._clModel),
_fMin(rclCF._fMin),
_fMax(rclCF._fMax),
_fAscent(rclCF._fAscent),
_fConstant(rclCF._fConstant),
_usCtColors(rclCF._usCtColors),
_aclField(rclCF._aclField)
{
*this = rclCF;
}
ColorField& ColorField::operator = (const ColorField &rclCF)
@@ -160,6 +165,7 @@ void ColorField::interpolate (Color clCol1, unsigned short usInd1, Color clCol2,
ColorGradient::ColorGradient (void)
: _tColorModel(TRIA),
_tStyle(ZERO_BASED),
_bOutsideGrayed(false),
_clTotal(ColorModelTria()),
_clTop(ColorModelTriaTop()),
@@ -171,6 +177,7 @@ ColorGradient::ColorGradient (void)
ColorGradient::ColorGradient (float fMin, float fMax, unsigned short usCtColors, TStyle tS, bool bOG)
: _tColorModel(TRIA),
_tStyle(tS),
_bOutsideGrayed(false),
_clTotal(ColorModelTria()),
_clTop(ColorModelTriaTop()),
@@ -181,12 +188,18 @@ ColorGradient::ColorGradient (float fMin, float fMax, unsigned short usCtColors,
}
ColorGradient::ColorGradient (const ColorGradient &rclCR)
: _tColorModel(TRIA),
_clTotal(ColorModelTria()),
_clTop(ColorModelTriaTop()),
_clBottom(ColorModelTriaBottom())
: _clColFld1(rclCR._clColFld1),
_clColFld2(rclCR._clColFld2),
_tColorModel(rclCR._tColorModel),
_tStyle(rclCR._tStyle),
_fMin(rclCR._fMin),
_fMax(rclCR._fMax),
_usCtColors(rclCR._usCtColors),
_bOutsideGrayed(rclCR._bOutsideGrayed),
_clTotal(rclCR._clTotal),
_clTop(rclCR._clTop),
_clBottom(rclCR._clBottom)
{
*this = rclCR;
}
ColorGradient& ColorGradient::operator = (const ColorGradient &rclCR)
@@ -245,9 +258,9 @@ unsigned short ColorGradient::getMinColors (void) const
{
switch (_tStyle)
{
case FLOW:
case FLOW:
return _clColFld1.getMinColors();
case ZERO_BASED:
case ZERO_BASED:
{
if ((_fMin < 0.0f) && (_fMax > 0.0f))
return _clColFld1.getMinColors() + _clColFld2.getMinColors();
@@ -301,13 +314,13 @@ void ColorGradient::setColorModel (void)
switch (_tStyle)
{
case FLOW:
case FLOW:
{
_clColFld1.setColorModel(_clTotal);
_clColFld2.setColorModel(_clBottom);
break;
}
case ZERO_BASED:
case ZERO_BASED:
{
_clColFld1.setColorModel(_clTop);
_clColFld2.setColorModel(_clBottom);