From b01d0e518170c1a7dd97e9ddb78742aa493c5aaa Mon Sep 17 00:00:00 2001
From: Chris Hennes <chennes@pioneerlibrarysystem.org>
Date: Sun, 10 Oct 2021 22:42:46 -0500
Subject: [PATCH] [Gui] Always hide progress bar on finished load

The loadFinished signal from QtWebEngine includes a boolean indicating
whether the load was "ssuccessful" or not, but no apparent way to
determine what error, if any, occurred. Given that we are never
displaying any error information to the user, hide the progress bar
regardless of the success or failure of the operation.
---
 src/Mod/Web/Gui/BrowserView.cpp | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/Mod/Web/Gui/BrowserView.cpp b/src/Mod/Web/Gui/BrowserView.cpp
index 0c776f066b..f3390c35eb 100644
--- a/src/Mod/Web/Gui/BrowserView.cpp
+++ b/src/Mod/Web/Gui/BrowserView.cpp
@@ -693,12 +693,10 @@ void BrowserView::onLoadProgress(int step)
 
 void BrowserView::onLoadFinished(bool ok)
 {
-    if (ok) {
-        QProgressBar* bar = SequencerBar::instance()->getProgressBar();
-        bar->setValue(100);
-        bar->hide();
-        getMainWindow()->showMessage(QString());
-    }
+    QProgressBar* bar = SequencerBar::instance()->getProgressBar();
+    bar->setValue(100);
+    bar->hide();
+    getMainWindow()->showMessage(QString());
     isLoading = false;
 }