From b04f1244a4efcb923d679e18e3078cebe4da9b5f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ji=C5=99=C3=AD=20Pinkava?= Date: Mon, 9 Sep 2024 13:37:32 +0200 Subject: [PATCH] Sketcher: clean-up geometry history configuation Keep code almost 1:1 with LS3 branch, just ensure the variable is initialized and code is documented --- src/Mod/Sketcher/App/SketchObject.cpp | 5 +---- src/Mod/Sketcher/App/SketchObject.h | 3 ++- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/Mod/Sketcher/App/SketchObject.cpp b/src/Mod/Sketcher/App/SketchObject.cpp index a3f7336cba..ba9bedba3d 100644 --- a/src/Mod/Sketcher/App/SketchObject.cpp +++ b/src/Mod/Sketcher/App/SketchObject.cpp @@ -127,7 +127,7 @@ FC_LOG_LEVEL_INIT("Sketch", true, true) PROPERTY_SOURCE(Sketcher::SketchObject, Part::Part2DObject) -SketchObject::SketchObject() +SketchObject::SketchObject() : geoLastId(0) { ADD_PROPERTY_TYPE( Geometry, (nullptr), "Sketch", (App::PropertyType)(App::Prop_None), "Sketch geometry"); @@ -164,9 +164,6 @@ SketchObject::SketchObject() "Sketch", (App::PropertyType)(App::Prop_None), "Tolerance for fitting arcs of projected external geometry"); - geoLastId = 0; - geoHistoryLevel = 1; - ADD_PROPERTY(InternalShape, (Part::TopoShape())); ADD_PROPERTY_TYPE(MakeInternals, diff --git a/src/Mod/Sketcher/App/SketchObject.h b/src/Mod/Sketcher/App/SketchObject.h index 1b6239691f..fd5c675207 100644 --- a/src/Mod/Sketcher/App/SketchObject.h +++ b/src/Mod/Sketcher/App/SketchObject.h @@ -1062,7 +1062,8 @@ private: // mapping from Geometry[*].Id to index of Geometry std::map geoMap; - int geoHistoryLevel; + // keep geoHistoryLevel and the code who ise it for easier porting of stuff from LS3 branch + const int geoHistoryLevel = 1; std::vector geoIdHistory; long geoLastId;