From b1dd0bd2d03f164e93b3aefb90bb53db685cdda9 Mon Sep 17 00:00:00 2001
From: Wanderer Fan <wandererfan@gmail.com>
Date: Fri, 29 Jul 2022 12:48:35 -0400
Subject: [PATCH] [TD]add preference for progress reporting

---
 src/Mod/TechDraw/App/DrawView.cpp             |  6 +++--
 src/Mod/TechDraw/App/Preferences.cpp          |  9 ++++++++
 src/Mod/TechDraw/App/Preferences.h            |  1 +
 .../TechDraw/Gui/DlgPrefsTechDrawAdvanced.ui  | 22 ++++++++++++++++---
 .../Gui/DlgPrefsTechDrawAdvancedImp.cpp       |  2 ++
 5 files changed, 35 insertions(+), 5 deletions(-)

diff --git a/src/Mod/TechDraw/App/DrawView.cpp b/src/Mod/TechDraw/App/DrawView.cpp
index e648fa28f0..d7a3ea3f79 100644
--- a/src/Mod/TechDraw/App/DrawView.cpp
+++ b/src/Mod/TechDraw/App/DrawView.cpp
@@ -582,8 +582,10 @@ void DrawView::requestPaint()
 }
 
 void DrawView::showProgressMessage(std::string featureName, std::string text)
-{    
-    signalProgressMessage(this, featureName, text);
+{
+    if (Preferences::reportProgress()) {
+        signalProgressMessage(this, featureName, text);
+    }
 }
 
 PyObject *DrawView::getPyObject(void)
diff --git a/src/Mod/TechDraw/App/Preferences.cpp b/src/Mod/TechDraw/App/Preferences.cpp
index 9a79c50217..096f19a6f5 100644
--- a/src/Mod/TechDraw/App/Preferences.cpp
+++ b/src/Mod/TechDraw/App/Preferences.cpp
@@ -339,3 +339,12 @@ double Preferences::GapASME()
     double factor = hGrp->GetFloat("GapASME", 6.0);
     return factor;
 }
+
+bool Preferences::reportProgress()
+{
+    Base::Reference<ParameterGrp>  hGrp = App::GetApplication().GetUserParameter().
+                                          GetGroup("BaseApp")->GetGroup("Preferences")->
+                                          GetGroup("Mod/TechDraw/General");
+    bool report = hGrp->GetBool("ReportProgress", false);
+    return report;
+}
diff --git a/src/Mod/TechDraw/App/Preferences.h b/src/Mod/TechDraw/App/Preferences.h
index a3c4984d10..7eacaec1e9 100644
--- a/src/Mod/TechDraw/App/Preferences.h
+++ b/src/Mod/TechDraw/App/Preferences.h
@@ -81,6 +81,7 @@ static std::string bitmapFill();
 static double      GapISO();
 static double      GapASME();
 
+static bool        reportProgress();
 };
 
 } //end namespace TechDraw
diff --git a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvanced.ui b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvanced.ui
index 96f55db62e..02ef961dcb 100644
--- a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvanced.ui
+++ b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvanced.ui
@@ -242,7 +242,7 @@ can be a performance penalty in complex models.</string>
           </property>
          </widget>
         </item>
-       <item row="4" column="0">
+        <item row="4" column="0">
          <widget class="QLabel" name="label_5">
           <property name="minimumSize">
            <size>
@@ -499,7 +499,23 @@ when hatching a face with a PAT pattern</string>
           </property>
          </widget>
         </item>
-        </layout>
+        <item row="3" column="2">
+         <widget class="Gui::PrefCheckBox" name="cbReportProgress">
+          <property name="toolTip">
+           <string>Issue progress messages while building View geometry</string>
+          </property>
+          <property name="text">
+           <string>Report Progress</string>
+          </property>
+          <property name="prefEntry" stdset="0">
+           <cstring>ReportProgress</cstring>
+          </property>
+          <property name="prefPath" stdset="0">
+           <cstring>/Mod/TechDraw/General</cstring>
+          </property>
+         </widget>
+        </item>
+       </layout>
       </item>
      </layout>
     </widget>
@@ -513,7 +529,7 @@ when hatching a face with a PAT pattern</string>
       </font>
      </property>
      <property name="text">
-      <string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;&lt;span style=" font-weight:600;"&gt;Note:&lt;/span&gt; Items in &lt;span style=" font-style:italic;"&gt;italics&lt;/span&gt; are default values for new objects. They have no effect on existing objects.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
+      <string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;&lt;span style=&quot; font-weight:600;&quot;&gt;Note:&lt;/span&gt; Items in &lt;span style=&quot; font-style:italic;&quot;&gt;italics&lt;/span&gt; are default values for new objects. They have no effect on existing objects.&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
      </property>
      <property name="textFormat">
       <enum>Qt::RichText</enum>
diff --git a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvancedImp.cpp b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvancedImp.cpp
index 746678620d..ccb567efb0 100644
--- a/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvancedImp.cpp
+++ b/src/Mod/TechDraw/Gui/DlgPrefsTechDrawAdvancedImp.cpp
@@ -57,6 +57,7 @@ void DlgPrefsTechDrawAdvancedImp::saveSettings()
     ui->cbEndCap->onSave();
     ui->sbMaxTiles->onSave();
     ui->sbMaxPat->onSave();
+    ui->cbReportProgress->onSave();
 }
 
 void DlgPrefsTechDrawAdvancedImp::loadSettings()
@@ -73,6 +74,7 @@ void DlgPrefsTechDrawAdvancedImp::loadSettings()
     ui->cbEndCap->onRestore();
     ui->sbMaxTiles->onRestore();
     ui->sbMaxPat->onRestore();
+    ui->cbReportProgress->onRestore();
 }
 
 /**