From b2fac5929b1a38d8290105efad1118e16f7b301c Mon Sep 17 00:00:00 2001
From: wmayer <wmayer@users.sourceforge.net>
Date: Sun, 24 Sep 2017 12:22:53 +0200
Subject: [PATCH] fix clang warnings in some 3rd party libs

---
 src/3rdParty/salomesmesh/src/SMESH/MED_Structures.cpp | 10 ++++++----
 src/Mod/Robot/App/kdl_cp/chaindynparam.cpp            |  2 +-
 src/Mod/Robot/App/kdl_cp/chaindynparam.hpp            |  2 +-
 src/Mod/Robot/App/kdl_cp/joint.cpp                    |  1 +
 4 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/src/3rdParty/salomesmesh/src/SMESH/MED_Structures.cpp b/src/3rdParty/salomesmesh/src/SMESH/MED_Structures.cpp
index 2a105fa445..cc23efd89a 100644
--- a/src/3rdParty/salomesmesh/src/SMESH/MED_Structures.cpp
+++ b/src/3rdParty/salomesmesh/src/SMESH/MED_Structures.cpp
@@ -367,11 +367,13 @@ bool
 TGaussInfo::TLess
 ::operator()(const TGaussInfo& theLeft, const TGaussInfo& theRight) const
 {
-  if(!&theLeft)
-    return true;
+  //clang: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code;
+  //       pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
+  //if(!&theLeft)
+  //  return true;
 
-  if(!&theRight)
-    return false;
+  //if(!&theRight)
+  //  return false;
 
   if(theLeft.myGeom != theRight.myGeom)
     return theLeft.myGeom < theRight.myGeom;
diff --git a/src/Mod/Robot/App/kdl_cp/chaindynparam.cpp b/src/Mod/Robot/App/kdl_cp/chaindynparam.cpp
index b18346af18..43f8d5bb49 100644
--- a/src/Mod/Robot/App/kdl_cp/chaindynparam.cpp
+++ b/src/Mod/Robot/App/kdl_cp/chaindynparam.cpp
@@ -27,7 +27,7 @@ namespace KDL {
 
     ChainDynParam::ChainDynParam(const Chain& _chain, Vector _grav):
             chain(_chain),
-            nr(0),
+            //nr(0),
             nj(chain.getNrOfJoints()),
             ns(chain.getNrOfSegments()),
             grav(_grav),
diff --git a/src/Mod/Robot/App/kdl_cp/chaindynparam.hpp b/src/Mod/Robot/App/kdl_cp/chaindynparam.hpp
index 2592de3184..16f250e41e 100644
--- a/src/Mod/Robot/App/kdl_cp/chaindynparam.hpp
+++ b/src/Mod/Robot/App/kdl_cp/chaindynparam.hpp
@@ -55,7 +55,7 @@ namespace KDL {
 
     private:
         const Chain chain;
-	int nr;
+	//int nr;
 	unsigned int nj;
         unsigned int ns;
 	Vector grav;
diff --git a/src/Mod/Robot/App/kdl_cp/joint.cpp b/src/Mod/Robot/App/kdl_cp/joint.cpp
index e487334b80..a942dad5b6 100644
--- a/src/Mod/Robot/App/kdl_cp/joint.cpp
+++ b/src/Mod/Robot/App/kdl_cp/joint.cpp
@@ -156,6 +156,7 @@ namespace KDL {
 
   Vector Joint::JointOrigin() const
   {
+    (void)inertia; (void)damping; (void)stiffness;
     return origin;
   }