From b58245b7b4ac7e4bc47aa9c239c09e3fdfd8bfd0 Mon Sep 17 00:00:00 2001 From: Markus Hovorka Date: Wed, 12 Jun 2019 21:44:49 +0200 Subject: [PATCH] FEM: Remove unnecessary overrides from Analysis onChanged, execute, mustExecute and getPyObject where overwritten but the implementation didn't do anything different from the implementation of the base class DocumentObject in this case. Thus they where redundent. --- src/Mod/Fem/App/FemAnalysis.cpp | 15 --------------- src/Mod/Fem/App/FemAnalysis.h | 15 +++------------ 2 files changed, 3 insertions(+), 27 deletions(-) diff --git a/src/Mod/Fem/App/FemAnalysis.cpp b/src/Mod/Fem/App/FemAnalysis.cpp index 90a8ed392d..2d60e2e03d 100644 --- a/src/Mod/Fem/App/FemAnalysis.cpp +++ b/src/Mod/Fem/App/FemAnalysis.cpp @@ -48,21 +48,6 @@ FemAnalysis::~FemAnalysis() { } -short FemAnalysis::mustExecute(void) const -{ - return 0; -} - -PyObject *FemAnalysis::getPyObject() -{ - return App::DocumentObjectGroup::getPyObject(); -} - -void FemAnalysis::onChanged(const Property* prop) -{ - App::DocumentObjectGroup::onChanged(prop); -} - void FemAnalysis::handleChangedPropertyName(Base::XMLReader &reader, const char * TypeName, const char *PropName) diff --git a/src/Mod/Fem/App/FemAnalysis.h b/src/Mod/Fem/App/FemAnalysis.h index 1c03575935..2c9458c2dd 100644 --- a/src/Mod/Fem/App/FemAnalysis.h +++ b/src/Mod/Fem/App/FemAnalysis.h @@ -43,23 +43,14 @@ public: FemAnalysis(void); virtual ~FemAnalysis(); - /// returns the type name of the ViewProvider - virtual const char* getViewProviderName(void) const { - return "FemGui::ViewProviderFemAnalysis"; - } - virtual App::DocumentObjectExecReturn *execute(void) { - return App::DocumentObject::StdReturn; - } - virtual short mustExecute(void) const; - virtual PyObject *getPyObject(void); - /// unique identifier of the Analysis App::PropertyUUID Uid; + virtual const char* getViewProviderName() const { + return "FemGui::ViewProviderFemAnalysis"; + } protected: - /// get called by the container when a property has changed - virtual void onChanged (const App::Property* prop); /// Support of backward compatibility virtual void handleChangedPropertyName(Base::XMLReader &reader, const char * TypeName,