kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Part/Sketcher: Refactor Geometry Extensions copy/save/restore AND attachment notification

Browse Source 
=========================================================================================

- Long overdue refactor to avoid repetition during save/restore and copy.
- New interface to notify an extension when it is attached. It also enables the extension to gain
a pointer to the geometry container. This is intended to extend the functionality already existing
in Part::Geometry.
This commit is contained in:
Abdullah Tahiri
2021-01-08 14:18:52 +01:00
committed by abdullahtahiriyo
parent 6c6790e8b5
commit b69b3c71c0
14 changed files with 141 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/Mod/Sketcher/App/ExternalGeometryExtension.cpp
View File

@@ -37,36 +37,35 @@ constexpr std::array<const char *, ExternalGeometryExtension::NumFlags> External
TYPESYSTEM_SOURCE(Sketcher::ExternalGeometryExtension,Part::GeometryPersistenceExtension)
// Persistence implementer
void ExternalGeometryExtension::Save(Base::Writer &writer) const
void ExternalGeometryExtension::copyAttributes(Part::GeometryExtension * cpy) const
{
writer.Stream() << writer.ind() << "<GeoExtension type=\"" << this->getTypeId().getName();
Part::GeometryPersistenceExtension::copyAttributes(cpy);
const std::string name = getName();
if(name.size() > 0)
writer.Stream() << "\" name=\"" << name;
writer.Stream() << "\" Ref=\"" << Ref << "\" Flags=\"" << Flags.to_string() << "\"/>" << std::endl;
static_cast<ExternalGeometryExtension *>(cpy)->Ref = this->Ref;
static_cast<ExternalGeometryExtension *>(cpy)->Flags = this->Flags;
}
void ExternalGeometryExtension::Restore(Base::XMLReader &reader)
void ExternalGeometryExtension::restoreAttributes(Base::XMLReader &reader)
{
restoreNameAttribute(reader);
Part::GeometryPersistenceExtension::restoreAttributes(reader);
Ref = reader.getAttribute("Ref");
Flags = FlagType(reader.getAttribute("Flags"));
}
void ExternalGeometryExtension::saveAttributes(Base::Writer &writer) const
{
Part::GeometryPersistenceExtension::saveAttributes(writer);
writer.Stream() << "\" Ref=\"" << Ref
<< "\" Flags=\"" << Flags.to_string();
}
std::unique_ptr<Part::GeometryExtension> ExternalGeometryExtension::copy(void) const
{
auto cpy = std::make_unique<ExternalGeometryExtension>();
cpy->Ref = this->Ref;
cpy->Flags = this->Flags;
cpy->setName(this->getName()); // Base Class
copyAttributes(cpy.get());
#if defined (__GNUC__) && (__GNUC__ <=4)
return std::move(cpy);