From b7c6ffe785e7d167391ef7449ec2e16462147419 Mon Sep 17 00:00:00 2001 From: PaddleStroke Date: Mon, 1 Jul 2024 16:31:32 +0200 Subject: [PATCH] Sketcher: scale/translate: fix OVP warning if disabled --- src/Mod/Sketcher/Gui/DrawSketchHandlerScale.h | 3 +-- src/Mod/Sketcher/Gui/DrawSketchHandlerTranslate.h | 11 +++++------ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/Mod/Sketcher/Gui/DrawSketchHandlerScale.h b/src/Mod/Sketcher/Gui/DrawSketchHandlerScale.h index a3434a3dcc..6e7a8dc2e2 100644 --- a/src/Mod/Sketcher/Gui/DrawSketchHandlerScale.h +++ b/src/Mod/Sketcher/Gui/DrawSketchHandlerScale.h @@ -473,8 +473,7 @@ void DSHScaleController::adaptParameters(Base::Vector2d onSketchPos) } break; case SelectMode::SeekThird: { if (!onViewParameters[OnViewParameter::Third]->isSet) { - onViewParameters[OnViewParameter::Third]->setSpinboxValue(handler->scaleFactor, - Base::Unit()); + setOnViewParameterValue(OnViewParameter::Third, handler->scaleFactor, Base::Unit()); } Base::Vector3d start = toVector3d(handler->referencePoint); diff --git a/src/Mod/Sketcher/Gui/DrawSketchHandlerTranslate.h b/src/Mod/Sketcher/Gui/DrawSketchHandlerTranslate.h index 5c0d3cb07d..d71fdfe4e1 100644 --- a/src/Mod/Sketcher/Gui/DrawSketchHandlerTranslate.h +++ b/src/Mod/Sketcher/Gui/DrawSketchHandlerTranslate.h @@ -640,8 +640,8 @@ void DSHTranslateController::adaptParameters(Base::Vector2d onSketchPos) } break; case SelectMode::SeekSecond: { if (!onViewParameters[OnViewParameter::Third]->isSet) { - onViewParameters[OnViewParameter::Third]->setSpinboxValue( - (onSketchPos - handler->referencePoint).Length()); + double length = (onSketchPos - handler->referencePoint).Length(); + setOnViewParameterValue(OnViewParameter::Third, length); } Base::Vector2d vec2d = Base::Vector2d(handler->firstTranslationVector.x, @@ -650,8 +650,7 @@ void DSHTranslateController::adaptParameters(Base::Vector2d onSketchPos) double range = angle * 180 / M_PI; if (!onViewParameters[OnViewParameter::Fourth]->isSet) { - onViewParameters[OnViewParameter::Fourth]->setSpinboxValue(range, - Base::Unit::Angle); + setOnViewParameterValue(OnViewParameter::Fourth, range, Base::Unit::Angle); } Base::Vector3d start = toVector3d(handler->referencePoint); @@ -663,8 +662,8 @@ void DSHTranslateController::adaptParameters(Base::Vector2d onSketchPos) } break; case SelectMode::SeekThird: { if (!onViewParameters[OnViewParameter::Fifth]->isSet) { - onViewParameters[OnViewParameter::Fifth]->setSpinboxValue( - (onSketchPos - handler->referencePoint).Length()); + double length = (onSketchPos - handler->referencePoint).Length(); + setOnViewParameterValue(OnViewParameter::Fifth, length); } Base::Vector2d vec2d = Base::Vector2d(handler->secondTranslationVector.x,