kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Merge pull request #19917 from tritao/refactor-document-recompute

Browse Source 
Core: Refactor code around document and feature recompute
This commit is contained in:
Chris Hennes
2025-03-16 23:59:12 -05:00
committed by GitHub
parent 89e20d561d 77203eaa06
commit b89ad30bc0
13 changed files with 73 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/Gui/CommandDoc.cpp
View File

@@ -1487,24 +1487,25 @@ StdCmdRefresh::StdCmdRefresh()
eType = eType | NoTransaction;
}
void StdCmdRefresh::activated(int iMsg)
void StdCmdRefresh::activated([[maybe_unused]] int iMsg)
{
Q_UNUSED(iMsg);
if (getActiveGuiDocument()) {
App::AutoTransaction trans((eType & NoTransaction) ? nullptr : "Recompute");
try {
doCommand(Doc,"App.activeDocument().recompute(None,True,True)");
}
catch (Base::Exception& /*e*/) {
auto ret = QMessageBox::warning(getMainWindow(), QObject::tr("Dependency error"),
qApp->translate("Std_Refresh", "The document contains dependency cycles.\n"
"Please check the Report View for more details.\n\n"
"Do you still want to proceed?"),
QMessageBox::Yes, QMessageBox::No);
if(ret == QMessageBox::No)
return;
doCommand(Doc,"App.activeDocument().recompute(None,True)");
}
if (!getActiveGuiDocument()) {
return;
}
App::AutoTransaction trans((eType & NoTransaction) ? nullptr : "Recompute");
try {
doCommand(Doc,"App.activeDocument().recompute(None,True,True)");
}
catch (Base::Exception& /*e*/) {
auto ret = QMessageBox::warning(getMainWindow(), QObject::tr("Dependency error"),
qApp->translate("Std_Refresh", "The document contains dependency cycles.\n"
"Please check the Report View for more details.\n\n"
"Do you still want to proceed?"),
QMessageBox::Yes, QMessageBox::No);
if(ret == QMessageBox::No)
return;
doCommand(Doc,"App.activeDocument().recompute(None,True)");
}
}