From b8d2a881025c00d48337f50b44aba6ce2cd5154a Mon Sep 17 00:00:00 2001
From: wmayer <wmayer@users.sourceforge.net>
Date: Thu, 22 Dec 2022 20:26:39 +0100
Subject: [PATCH] Gui: fix several warnings reported by GH actions

---
 src/Gui/MDIViewPyWrap.cpp | 46 +++++++++++++++++++--------------------
 src/Gui/MDIViewPyWrap.h   |  2 +-
 2 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/src/Gui/MDIViewPyWrap.cpp b/src/Gui/MDIViewPyWrap.cpp
index 3e29a15568..653d7dddcd 100644
--- a/src/Gui/MDIViewPyWrap.cpp
+++ b/src/Gui/MDIViewPyWrap.cpp
@@ -135,7 +135,7 @@ public:
         Py::Callable target(func.at("undoActions"));
         Py::List list(target.apply(Py::Tuple()));
         QStringList actions;
-        for (auto it : list) {
+        for (const auto& it : list) {
             Py::String str(it);
             actions << QString::fromStdString(str);
         }
@@ -148,7 +148,7 @@ public:
         Py::Callable target(func.at("redoActions"));
         Py::List list(target.apply(Py::Tuple()));
         QStringList actions;
-        for (auto it : list) {
+        for (const auto& it : list) {
             Py::String str(it);
             actions << QString::fromStdString(str);
         }
@@ -165,7 +165,7 @@ private:
 
 TYPESYSTEM_SOURCE_ABSTRACT(Gui::MDIViewPyWrap,Gui::MDIView)
 
-MDIViewPyWrap::MDIViewPyWrap(Py::Object py, Gui::Document* pcDocument,QWidget* parent, Qt::WindowFlags wflags)
+MDIViewPyWrap::MDIViewPyWrap(const Py::Object& py, Gui::Document* pcDocument,QWidget* parent, Qt::WindowFlags wflags)
   : MDIView(pcDocument, parent, wflags)
   , ptr(std::make_unique<MDIViewPyWrapImp>(py))
 {
@@ -177,8 +177,8 @@ MDIViewPyWrap::MDIViewPyWrap(Py::Object py, Gui::Document* pcDocument,QWidget* p
     }
     catch (Py::Exception&) {
         Base::PyGILStateLocker lock;
-        Base::PyException e;
-        e.ReportException();
+        Base::PyException exc;
+        exc.ReportException();
     }
 }
 
@@ -205,8 +205,8 @@ bool MDIViewPyWrap::onMsg(const char* pMsg,const char** ppReturn)
     }
     catch (Py::Exception&) {
         Base::PyGILStateLocker lock;
-        Base::PyException e;
-        e.ReportException();
+        Base::PyException exc;
+        exc.ReportException();
         return false;
     }
 }
@@ -224,8 +224,8 @@ bool MDIViewPyWrap::onHasMsg(const char* pMsg) const
     }
     catch (Py::Exception&) {
         Base::PyGILStateLocker lock;
-        Base::PyException e;
-        e.ReportException();
+        Base::PyException exc;
+        exc.ReportException();
         return false;
     }
 }
@@ -240,8 +240,8 @@ bool MDIViewPyWrap::canClose()
     }
     catch (Py::Exception&) {
         Base::PyGILStateLocker lock;
-        Base::PyException e;
-        e.ReportException();
+        Base::PyException exc;
+        exc.ReportException();
         return false;
     }
 }
@@ -256,8 +256,8 @@ void MDIViewPyWrap::print(QPrinter* printer)
     }
     catch (Py::Exception&) {
         Base::PyGILStateLocker lock;
-        Base::PyException e;
-        e.ReportException();
+        Base::PyException exc;
+        exc.ReportException();
     }
 }
 
@@ -271,8 +271,8 @@ void MDIViewPyWrap::print()
     }
     catch (Py::Exception&) {
         Base::PyGILStateLocker lock;
-        Base::PyException e;
-        e.ReportException();
+        Base::PyException exc;
+        exc.ReportException();
     }
 }
 
@@ -286,8 +286,8 @@ void MDIViewPyWrap::printPdf()
     }
     catch (Py::Exception&) {
         Base::PyGILStateLocker lock;
-        Base::PyException e;
-        e.ReportException();
+        Base::PyException exc;
+        exc.ReportException();
     }
 }
 
@@ -301,8 +301,8 @@ void MDIViewPyWrap::printPreview()
     }
     catch (Py::Exception&) {
         Base::PyGILStateLocker lock;
-        Base::PyException e;
-        e.ReportException();
+        Base::PyException exc;
+        exc.ReportException();
     }
 }
 
@@ -316,8 +316,8 @@ QStringList MDIViewPyWrap::undoActions() const
     }
     catch (Py::Exception&) {
         Base::PyGILStateLocker lock;
-        Base::PyException e;
-        e.ReportException();
+        Base::PyException exc;
+        exc.ReportException();
         return MDIView::undoActions();
     }
 }
@@ -332,8 +332,8 @@ QStringList MDIViewPyWrap::redoActions() const
     }
     catch (Py::Exception&) {
         Base::PyGILStateLocker lock;
-        Base::PyException e;
-        e.ReportException();
+        Base::PyException exc;
+        exc.ReportException();
         return MDIView::redoActions();
     }
 }
diff --git a/src/Gui/MDIViewPyWrap.h b/src/Gui/MDIViewPyWrap.h
index 09ac3354a2..d41eb2f7ef 100644
--- a/src/Gui/MDIViewPyWrap.h
+++ b/src/Gui/MDIViewPyWrap.h
@@ -44,7 +44,7 @@ public:
      * the view will attach to the active document. Be aware, there isn't
      * always an active document.
      */
-    MDIViewPyWrap(Py::Object py, Gui::Document* pcDocument, QWidget* parent=nullptr, Qt::WindowFlags wflags=Qt::WindowFlags());
+    explicit MDIViewPyWrap(const Py::Object& py, Gui::Document* pcDocument, QWidget* parent=nullptr, Qt::WindowFlags wflags=Qt::WindowFlags());
     /** View destructor
      * Detach the view from the document, if attached.
      */