Coverity: Dereference null return value

2020-07-19 16:21:20 +02:00
parent fdd6d341c7
commit ba683bf241
4 changed files with 23 additions and 13 deletions
--- a/src/Gui/Tree.cpp
+++ b/src/Gui/Tree.cpp
@@ -1823,8 +1823,8 @@ void TreeWidget::dropEvent(QDropEvent *event)
                std::string dropName;
                ss.str("");
                if(da == Qt::LinkAction) {
-                    if(targetItemObj->getParentItem()) {
-                        auto parentItem = targetItemObj->getParentItem();
+                    auto parentItem = targetItemObj->getParentItem();
+                    if (parentItem) {
                        ss << Command::getObjectCmd(
                                parentItem->object()->getObject(),0,".replaceObject(",true)
                            << Command::getObjectCmd(targetObj) << ","