kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

TechDraw: hard type enums, part 3 (#19418)

Browse Source 
* Remove magic number and hard type enums in LineNameEnum.h

- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.

* Remove magic number and hard type enums in QGIFace.h

- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.

* Remove magic number and hard type enums in Enums.h

- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.

* Remove magic number and hard type enums in QGVPage.h

- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.

* Remove magic number and hard type enums in TaskSurfaceFinishSymbols.h

- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.

* Remove magic number and hard type enums in QGTracker.h

- Remove currently present magic numbers
- Hard type enums, so magic numbers can no longer be introduced. We don't want people to introduce magic numbers.
This commit is contained in:
Benjamin Bræstrup Sayoc
2025-02-24 17:58:05 +01:00
committed by GitHub
parent 38797d1fa4
commit bf1f99c070
19 changed files with 161 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Mod/TechDraw/Gui/QGIDecoration.cpp
View File

@@ -41,7 +41,7 @@ QGIDecoration::QGIDecoration() :
m_colCurrent(Qt::black),
m_styleCurrent(Qt::SolidLine),
m_brushCurrent(Qt::SolidPattern),
m_dragState(DECORNODRAG)
m_dragState(DragState::NoDrag)
{
setCacheMode(QGraphicsItem::NoCache);
setAcceptHoverEvents(false);
@@ -125,15 +125,15 @@ void QGIDecoration::makeMark(Base::Vector3d v)
void QGIDecoration::mousePressEvent(QGraphicsSceneMouseEvent * event)
{
// Base::Console().Message("QGID::mousePressEvent() - %s\n", getViewName());
m_dragState = DECORDRAGSTARTED;
m_dragState = DragState::DragStarted;
QGraphicsItem::mousePressEvent(event);
}
void QGIDecoration::mouseMoveEvent(QGraphicsSceneMouseEvent * event)
{
if (m_dragState == DECORDRAGSTARTED) {
m_dragState = DECORDRAGGING;
if (m_dragState == DragState::DragStarted) {
m_dragState = DragState::Dragging;
}
QGraphicsItem::mouseMoveEvent(event);
}
@@ -141,10 +141,10 @@ void QGIDecoration::mouseMoveEvent(QGraphicsSceneMouseEvent * event)
void QGIDecoration::mouseReleaseEvent(QGraphicsSceneMouseEvent * event)
{
// Base::Console().Message("QGID::mouseReleaseEvent() - %s\n", getViewName());
if (m_dragState == DECORDRAGGING) {
if (m_dragState == DragState::Dragging) {
onDragFinished();
}
m_dragState = DECORNODRAG;
m_dragState = DragState::NoDrag;
QGraphicsItem::mouseReleaseEvent(event);
}