kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: Process minor review comments

Browse Source 
Co-authored-by: Kacper Donat <kadet1090@gmail.com>
This commit is contained in:
Pieter Hijma
2025-08-26 16:48:56 +02:00
parent 7eec8b5416
commit c0cb0b757e
1 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/Gui/Dialogs/DlgExpressionInput.cpp
View File

@@ -210,7 +210,12 @@ bool DlgExpressionInput::typeOkForVarSet()
void DlgExpressionInput::initializeErrorFrame()
{
ui->errorFrame->setVisible(false);
ui->errorIconLabel->setPixmap(style()->standardIcon(QStyle::SP_MessageBoxCritical).pixmap(QSize(20, 20)));
const int size = style()->pixelMetric(QStyle::PM_LargeIconSize);
QIcon icon = Gui::BitmapFactory().iconFromTheme("overlay_error");
if (icon.isNull()) {
icon = style()->standardIcon(QStyle::SP_MessageBoxCritical);
}
ui->errorIconLabel->setPixmap(icon.pixmap(QSize(size, size)));
}
void DlgExpressionInput::initializeVarSets()
@@ -780,12 +785,9 @@ void DlgExpressionInput::preselectGroup()
return;
}
int index = comboBoxGroup.findText(QString::fromStdString(lastGroup));
if (index == -1) {
return;
if (int index = comboBoxGroup.findText(QString::fromStdString(lastGroup)); index != -1) {
comboBoxGroup.setCurrentIndex(index);
}
comboBoxGroup.setCurrentIndex(index);
}
void DlgExpressionInput::onVarSetSelected(int /*index*/)
@@ -797,9 +799,13 @@ void DlgExpressionInput::onVarSetSelected(int /*index*/)
return;
}
App::DocumentObject* varSet = App::GetApplication().getDocument(
docName.toUtf8())->getObject(
varSetName.toUtf8());
App::Document* doc = App::GetApplication().getDocument(docName.toUtf8());
if (doc == nullptr) {
FC_ERR("Document not found: " << docName.toStdString());
return;
}
App::DocumentObject* varSet = doc->getObject(varSetName.toUtf8());
if (varSet == nullptr) {
FC_ERR("Variable set not found: " << varSetName.toStdString());
return;