App: fix property ordering problem when undo/redo (#3255)

* Part: fix Placement/Shape onChanged() handling

* App: fix property ordering problem when undo/redo
See https://tracker.freecadweb.org/view.php?id=4265#c14271

* Gui: fix undo/redo signaling
Make sure to signal after all properties has been restored

src/Mod/Part/App/PartFeature.cpp

@@ -62,6 +62,7 @@
 #include <Base/Stream.h>
 #include <Base/Placement.h>
 #include <Base/Rotation.h>
+#include <Base/Tools.h>
 #include <App/Application.h>
 #include <App/FeaturePythonPyImp.h>
 #include <App/Document.h>
@@ -540,8 +541,17 @@ void Feature::onChanged(const App::Property* prop)
 {
     // if the placement has changed apply the change to the point data as well
     if (prop == &this->Placement) {
-        TopoShape& shape = const_cast<TopoShape&>(this->Shape.getShape());
+        // The following code bypasses transaction, which may cause problem to
+        // undo/redo
+        //
+        // TopoShape& shape = const_cast<TopoShape&>(this->Shape.getShape());
+        // shape.setTransform(this->Placement.getValue().toMatrix());
+
+        TopoShape shape = this->Shape.getShape();
         shape.setTransform(this->Placement.getValue().toMatrix());
+        Base::ObjectStatusLocker<App::Property::Status, App::Property> guard(
+                App::Property::NoRecompute, &this->Shape);
+        this->Shape.setValue(shape);
     }
     // if the point data has changed check and adjust the transformation as well
     else if (prop == &this->Shape) {
@@ -554,8 +564,7 @@ void Feature::onChanged(const App::Property* prop)
             // shape must not be null to override the placement
             if (!this->Shape.getValue().IsNull()) {
                 p.fromMatrix(this->Shape.getShape().getTransform());
-                if (p != this->Placement.getValue())
-                    this->Placement.setValue(p);
+                this->Placement.setValueIfChanged(p);
             }
         }
     }

src/Mod/Part/Gui/ViewProviderExt.cpp

@@ -840,6 +840,12 @@ void ViewProviderPartExt::updateData(const App::Property* prop)
 {
     const char *propName = prop->getName();
     if (propName && (strcmp(propName, "Shape") == 0 || strstr(propName, "Touched") != nullptr)) {
+        TopoDS_Shape cShape = Part::Feature::getShape(getObject());
+        if(cachedShape.IsPartner(cShape)) {
+            Gui::ViewProviderGeometryObject::updateData(prop);
+            return;
+        }
+
         // calculate the visual only if visible
         if (isUpdateForced() || Visibility.getValue())
             updateVisual();
@@ -918,6 +924,7 @@ void ViewProviderPartExt::updateVisual()
     haction.apply(this->nodeset);
 
     TopoDS_Shape cShape = Part::Feature::getShape(getObject());
+    cachedShape = cShape;
     if (cShape.IsNull()) {
         coords  ->point      .setNum(0);
         norm    ->vector     .setNum(0);

src/Mod/Part/Gui/ViewProviderExt.h

@@ -188,6 +188,8 @@ private:
     static App::PropertyQuantityConstraint::Constraints angDeflectionRange;
     static const char* LightingEnums[];
     static const char* DrawStyleEnums[];
+
+    TopoDS_Shape cachedShape;
 };
 
 }