From c6c549cc64e4341ae9e7bfe98c251ecd1bf8291d Mon Sep 17 00:00:00 2001
From: donovaly <uwestoehr@lyx.org>
Date: Sun, 14 Jun 2020 02:05:04 +0200
Subject: [PATCH] [TD] use KeyboardTracking for section view dialog

use the keyboardTracking feature as we now also do for the detail view dialog
---
 src/Mod/TechDraw/Gui/TaskSectionView.cpp | 26 +++++++++++++-----------
 src/Mod/TechDraw/Gui/TaskSectionView.ui  | 12 +++++++++++
 2 files changed, 26 insertions(+), 12 deletions(-)

diff --git a/src/Mod/TechDraw/Gui/TaskSectionView.cpp b/src/Mod/TechDraw/Gui/TaskSectionView.cpp
index 6b571780d5..473e4e3a6f 100644
--- a/src/Mod/TechDraw/Gui/TaskSectionView.cpp
+++ b/src/Mod/TechDraw/Gui/TaskSectionView.cpp
@@ -176,13 +176,14 @@ void TaskSectionView::setUiPrimary()
     this->setToolTip(QObject::tr("Select at first an orientation"));
     enableAll(false);
 
-    //use editingFinished signal instead of valueChanged to prevent keyboard lock out
-    //valueChanged fires every keystroke causing a recompute.
     connect(ui->leSymbol, SIGNAL(editingFinished()), this, SLOT(onIdentifierChanged()));
-    connect(ui->sbScale, SIGNAL(editingFinished()), this, SLOT(onScaleChanged()));
-    connect(ui->sbOrgX, SIGNAL(editingFinished()), this, SLOT(onXChanged()));
-    connect(ui->sbOrgY, SIGNAL(editingFinished()), this, SLOT(onYChanged()));
-    connect(ui->sbOrgZ, SIGNAL(editingFinished()), this, SLOT(onZChanged()));
+
+    // the UI file uses keyboardTracking = false so that a recomputation
+    // will only be triggered when the arrow keys of the spinboxes are used
+    connect(ui->sbScale, SIGNAL(valueChanged(double)), this, SLOT(onScaleChanged()));
+    connect(ui->sbOrgX, SIGNAL(valueChanged(double)), this, SLOT(onXChanged()));
+    connect(ui->sbOrgY, SIGNAL(valueChanged(double)), this, SLOT(onYChanged()));
+    connect(ui->sbOrgZ, SIGNAL(valueChanged(double)), this, SLOT(onZChanged()));
 }
 
 void TaskSectionView::setUiEdit()
@@ -207,13 +208,14 @@ void TaskSectionView::setUiEdit()
     ui->sbOrgZ->setUnit(Base::Unit::Length);
     ui->sbOrgZ->setValue(origin.z);
 
-    //use editingFinished signal instead of valueChanged to prevent keyboard lock out
-    //valueChanged fires every keystroke causing a recompute.
     connect(ui->leSymbol, SIGNAL(editingFinished()), this, SLOT(onIdentifierChanged()));
-    connect(ui->sbScale, SIGNAL(editingFinished()), this, SLOT(onScaleChanged()));
-    connect(ui->sbOrgX, SIGNAL(editingFinished()), this, SLOT(onXChanged()));
-    connect(ui->sbOrgY, SIGNAL(editingFinished()), this, SLOT(onYChanged()));
-    connect(ui->sbOrgZ, SIGNAL(editingFinished()), this, SLOT(onZChanged()));
+
+    // the UI file uses keyboardTracking = false so that a recomputation
+    // will only be triggered when the arrow keys of the spinboxes are used
+    connect(ui->sbScale, SIGNAL(valueChanged(double)), this, SLOT(onScaleChanged()));
+    connect(ui->sbOrgX, SIGNAL(valueChanged(double)), this, SLOT(onXChanged()));
+    connect(ui->sbOrgY, SIGNAL(valueChanged(double)), this, SLOT(onYChanged()));
+    connect(ui->sbOrgZ, SIGNAL(valueChanged(double)), this, SLOT(onZChanged()));
 }
 
 //save the start conditions
diff --git a/src/Mod/TechDraw/Gui/TaskSectionView.ui b/src/Mod/TechDraw/Gui/TaskSectionView.ui
index 158dd94da4..390a646192 100644
--- a/src/Mod/TechDraw/Gui/TaskSectionView.ui
+++ b/src/Mod/TechDraw/Gui/TaskSectionView.ui
@@ -105,6 +105,9 @@
        <property name="toolTip">
         <string>Scale factor for the section view</string>
        </property>
+       <property name="keyboardTracking">
+        <bool>false</bool>
+       </property>
        <property name="minimum">
         <double>0.000000000000000</double>
        </property>
@@ -331,6 +334,9 @@
             <height>22</height>
            </size>
           </property>
+          <property name="keyboardTracking">
+           <bool>false</bool>
+          </property>
           <property name="unit" stdset="0">
            <string notr="true"/>
           </property>
@@ -369,6 +375,9 @@
             <height>22</height>
            </size>
           </property>
+          <property name="keyboardTracking">
+           <bool>false</bool>
+          </property>
           <property name="unit" stdset="0">
            <string notr="true"/>
           </property>
@@ -407,6 +416,9 @@
             <height>22</height>
            </size>
           </property>
+          <property name="keyboardTracking">
+           <bool>false</bool>
+          </property>
           <property name="unit" stdset="0">
            <string notr="true"/>
           </property>