From c9a0fae9db91c38f57f5222fdd4f14fc6c511026 Mon Sep 17 00:00:00 2001 From: wmayer Date: Sun, 20 Mar 2022 16:51:23 +0100 Subject: [PATCH] lgtm: [skip ci] FIXME comment Change FIXME or remove it --- src/App/FeatureTest.h | 2 +- src/Base/PyObjectBase.cpp | 2 +- src/Mod/Mesh/App/Core/MeshIO.cpp | 2 +- src/Mod/Mesh/App/PreCompiled.h | 2 -- src/Mod/Part/App/CrossSection.cpp | 2 +- src/Mod/PartDesign/App/FeatureHole.cpp | 2 +- src/Mod/Sketcher/App/Sketch.cpp | 2 +- 7 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/App/FeatureTest.h b/src/App/FeatureTest.h index e2592a1c54..0d99ac1234 100644 --- a/src/App/FeatureTest.h +++ b/src/App/FeatureTest.h @@ -108,7 +108,7 @@ public: /// recalculate the Feature virtual DocumentObjectExecReturn *execute(void); /// returns the type name of the ViewProvider - //FIXME: Probably it makes sense to have a view provider for unittests (e.g. Gui::ViewProviderTest) + //Hint: Probably it makes sense to have a view provider for unittests (e.g. Gui::ViewProviderTest) virtual const char* getViewProviderName(void) const { return "Gui::ViewProviderFeature"; } diff --git a/src/Base/PyObjectBase.cpp b/src/Base/PyObjectBase.cpp index 6cbefe4b0c..465c419b81 100644 --- a/src/Base/PyObjectBase.cpp +++ b/src/Base/PyObjectBase.cpp @@ -347,7 +347,7 @@ int PyObjectBase::__setattro(PyObject *obj, PyObject *attro, PyObject *value) const char *attr; attr = PyUnicode_AsUTF8(attro); - //FIXME: In general we don't allow to delete attributes (i.e. value=0). However, if we want to allow + //Hint: In general we don't allow to delete attributes (i.e. value=0). However, if we want to allow //we must check then in _setattr() of all subclasses whether value is 0. if ( value==nullptr ) { PyErr_Format(PyExc_AttributeError, "Cannot delete attribute: '%s'", attr); diff --git a/src/Mod/Mesh/App/Core/MeshIO.cpp b/src/Mod/Mesh/App/Core/MeshIO.cpp index 9fde9d8515..eca94ac74d 100644 --- a/src/Mod/Mesh/App/Core/MeshIO.cpp +++ b/src/Mod/Mesh/App/Core/MeshIO.cpp @@ -2137,7 +2137,7 @@ bool MeshOutput::SaveAny(const char* FileName, MeshIO::Format format) const // Compressed VRML is nothing else than a GZIP'ped VRML ascii file // str.close(); //Base::ogzstream gzip(FileName, std::ios::out | std::ios::binary); - //FIXME: The compression level seems to be higher than with ogzstream + //Hint: The compression level seems to be higher than with ogzstream //which leads to problems to load the wrz file in debug mode, the //application simply crashes. zipios::GZIPOutputStream gzip(str); diff --git a/src/Mod/Mesh/App/PreCompiled.h b/src/Mod/Mesh/App/PreCompiled.h index 35b6aaca28..b469d8d2eb 100644 --- a/src/Mod/Mesh/App/PreCompiled.h +++ b/src/Mod/Mesh/App/PreCompiled.h @@ -71,9 +71,7 @@ #include #include -// FIXME: Causes problem with boost/numeric/bindings/lapack/syev.hpp(117) #ifdef FC_OS_WIN32 -//# include #include #endif diff --git a/src/Mod/Part/App/CrossSection.cpp b/src/Mod/Part/App/CrossSection.cpp index be64cc8091..96b896c0a5 100644 --- a/src/Mod/Part/App/CrossSection.cpp +++ b/src/Mod/Part/App/CrossSection.cpp @@ -138,7 +138,7 @@ void CrossSection::sliceSolid(double d, const TopoDS_Shape& shape, std::list& edges, std::list& wires) const { - // FIXME: Use ShapeAnalysis_FreeBounds::ConnectEdgesToWires() as an alternative + // Hint: Use ShapeAnalysis_FreeBounds::ConnectEdgesToWires() as an alternative std::list edge_list = edges; while (edge_list.size() > 0) { BRepBuilderAPI_MakeWire mkWire; diff --git a/src/Mod/PartDesign/App/FeatureHole.cpp b/src/Mod/PartDesign/App/FeatureHole.cpp index d807848723..296db6fa0d 100644 --- a/src/Mod/PartDesign/App/FeatureHole.cpp +++ b/src/Mod/PartDesign/App/FeatureHole.cpp @@ -1678,7 +1678,7 @@ App::DocumentObjectExecReturn* Hole::execute(void) if (method == "Dimension") length = Depth.getValue(); else if (method == "UpToFirst") { - /* FIXME */ + /* TODO */ } else if (method == "ThroughAll") { length = getThroughAllLength(); diff --git a/src/Mod/Sketcher/App/Sketch.cpp b/src/Mod/Sketcher/App/Sketch.cpp index 827393b6b8..24bddae3c7 100644 --- a/src/Mod/Sketcher/App/Sketch.cpp +++ b/src/Mod/Sketcher/App/Sketch.cpp @@ -4176,7 +4176,7 @@ TopoShape Sketch::toShape(void) const } } - // FIXME: Use ShapeAnalysis_FreeBounds::ConnectEdgesToWires() as an alternative + // Hint: Use ShapeAnalysis_FreeBounds::ConnectEdgesToWires() as an alternative // // sort them together to wires while (edge_list.size() > 0) {