From cbf42ad3b0042ca1f577cb30d6ce282d14b42fea Mon Sep 17 00:00:00 2001
From: WandererFan <wandererfan@gmail.com>
Date: Sun, 25 Jun 2017 19:22:53 -0400
Subject: [PATCH] Coverity fixes

151677
151789  - OK as is
152005
152508
154871  - false positive
156593
163235
---
 src/Mod/TechDraw/App/DrawSVGTemplate.cpp   | 3 ++-
 src/Mod/TechDraw/Gui/CommandCreateDims.cpp | 1 +
 src/Mod/TechDraw/Gui/QGIHighlight.cpp      | 1 +
 src/Mod/TechDraw/Gui/QGISectionLine.cpp    | 3 +++
 src/Mod/TechDraw/Gui/TaskProjGroup.cpp     | 2 +-
 5 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/Mod/TechDraw/App/DrawSVGTemplate.cpp b/src/Mod/TechDraw/App/DrawSVGTemplate.cpp
index 9ac88d5234..75ad473c30 100644
--- a/src/Mod/TechDraw/App/DrawSVGTemplate.cpp
+++ b/src/Mod/TechDraw/App/DrawSVGTemplate.cpp
@@ -173,7 +173,8 @@ App::DocumentObjectExecReturn * DrawSVGTemplate::execute(void)
         //double t0, t1,t2,t3;
         float t0, t1,t2,t3;
         if(line.find("<!-- Title block") != std::string::npos) {
-            sscanf(line.c_str(), "%*s %*s %*s %f %f %f %f", &t0, &t1, &t2, &t3);    //eg "    <!-- Working space 10 10 410 287 -->"
+            (void) sscanf(line.c_str(), "%*s %*s %*s %f %f %f %f", &t0, &t1, &t2, &t3);    //eg "    <!-- Working space 10 10 410 287 -->"
+                                                                                           //coverity 151677
             blockDimensions = QRectF(t0, t1, t2 - t0, t3 - t1);
         }
 
diff --git a/src/Mod/TechDraw/Gui/CommandCreateDims.cpp b/src/Mod/TechDraw/Gui/CommandCreateDims.cpp
index 032aac2c67..f7158504b9 100644
--- a/src/Mod/TechDraw/Gui/CommandCreateDims.cpp
+++ b/src/Mod/TechDraw/Gui/CommandCreateDims.cpp
@@ -383,6 +383,7 @@ void CmdTechDrawNewDiameterDimension::activated(int iMsg)
     Base::Reference<ParameterGrp> hGrp = App::GetApplication().GetUserParameter()
         .GetGroup("BaseApp")->GetGroup("Preferences")->GetGroup("Mod/TechDraw/Dimensions");
     std::string diamSym = hGrp->GetASCII("DiameterSymbol","\xe2\x8c\x80");
+    diamSym = diamSym.substr (0,79);                                            //coverity 156593
     const char * format = "%value%";
     char formatSpec[80];
     std::strcpy (formatSpec,diamSym.c_str());
diff --git a/src/Mod/TechDraw/Gui/QGIHighlight.cpp b/src/Mod/TechDraw/Gui/QGIHighlight.cpp
index ed5dd7128f..43d54cd63d 100644
--- a/src/Mod/TechDraw/Gui/QGIHighlight.cpp
+++ b/src/Mod/TechDraw/Gui/QGIHighlight.cpp
@@ -41,6 +41,7 @@ using namespace TechDrawGui;
 
 QGIHighlight::QGIHighlight()
 {
+    m_refText = "";
     m_refSize = 0.0;
     m_circle = new QGraphicsEllipseItem();
     addToGroup(m_circle);
diff --git a/src/Mod/TechDraw/Gui/QGISectionLine.cpp b/src/Mod/TechDraw/Gui/QGISectionLine.cpp
index 8350ccc3b8..9e861d2f2f 100644
--- a/src/Mod/TechDraw/Gui/QGISectionLine.cpp
+++ b/src/Mod/TechDraw/Gui/QGISectionLine.cpp
@@ -41,6 +41,9 @@ using namespace TechDrawGui;
 
 QGISectionLine::QGISectionLine()
 {
+    m_symbol = "";
+    m_symSize = 0.0;
+    
     m_extLen = Rez::guiX(8.0);
     m_arrowSize = 0.0;
 
diff --git a/src/Mod/TechDraw/Gui/TaskProjGroup.cpp b/src/Mod/TechDraw/Gui/TaskProjGroup.cpp
index fb1d6ac0aa..22181cc949 100644
--- a/src/Mod/TechDraw/Gui/TaskProjGroup.cpp
+++ b/src/Mod/TechDraw/Gui/TaskProjGroup.cpp
@@ -279,7 +279,7 @@ void TaskProjGroup::nearestFraction(double val, int &n, int &d) const
 
     n = 1;  // numerator
     d = 1;  // denominator
-    double fraction = n / d;
+    double fraction = 1.0;                                                      //coverity 152005
     //double m = fabs(fraction - val);
 
     while (fabs(fraction - val) > 0.001) {