From ccc8ac65c5a04f7f6690c29dc08225216f201e85 Mon Sep 17 00:00:00 2001
From: Wanderer Fan <wandererfan@gmail.com>
Date: Mon, 2 May 2022 13:51:04 -0400
Subject: [PATCH] [TD]fix X,Y change propagation

- X,Y changes to object1 were not propagated to
  object2 linked by expression
---
 src/Mod/TechDraw/App/DrawView.cpp | 25 ++++++-------------------
 src/Mod/TechDraw/App/DrawView.h   |  1 -
 2 files changed, 6 insertions(+), 20 deletions(-)

diff --git a/src/Mod/TechDraw/App/DrawView.cpp b/src/Mod/TechDraw/App/DrawView.cpp
index df9552a64d..c5be0e92f7 100644
--- a/src/Mod/TechDraw/App/DrawView.cpp
+++ b/src/Mod/TechDraw/App/DrawView.cpp
@@ -77,8 +77,8 @@ DrawView::DrawView(void):
     mouseMove(false)
 {
     static const char *group = "Base";
-    ADD_PROPERTY_TYPE(X, (0.0), group, (App::PropertyType)(App::Prop_Output | App::Prop_NoRecompute), "X position");
-    ADD_PROPERTY_TYPE(Y, (0.0), group, (App::PropertyType)(App::Prop_Output | App::Prop_NoRecompute), "Y position");
+    ADD_PROPERTY_TYPE(X, (0.0), group, (App::PropertyType)(App::Prop_None), "X position");
+    ADD_PROPERTY_TYPE(Y, (0.0), group, (App::PropertyType)(App::Prop_None), "Y position");
     ADD_PROPERTY_TYPE(LockPosition, (false), group, App::Prop_Output, "Lock View position to parent Page or Group");
     ADD_PROPERTY_TYPE(Rotation, (0.0), group, App::Prop_Output, "Rotation in degrees counterclockwise");
 
@@ -96,19 +96,6 @@ DrawView::~DrawView()
 {
 }
 
-App::DocumentObjectExecReturn *DrawView::recompute(void)
-{
-    try {
-        return App::DocumentObject::recompute();
-    }
-    catch (Standard_Failure& e) {
-        App::DocumentObjectExecReturn* ret = new App::DocumentObjectExecReturn(e.GetMessageString());
-        if (ret->Why.empty())
-            ret->Why = "Unknown OCC exception";
-        return ret;
-    }
-}
-
 App::DocumentObjectExecReturn *DrawView::execute(void)
 {
 //    Base::Console().Message("DV::execute() - %s touched: %d\n", getNameInDocument(), isTouched());
@@ -117,11 +104,10 @@ App::DocumentObjectExecReturn *DrawView::execute(void)
     }
     handleXYLock();
     requestPaint();
-    //documentobject::execute doesn't do anything useful for us.
     //documentObject::recompute causes an infinite loop.
     //should not be necessary to purgeTouched here, but it prevents a superfluous feature recompute
     purgeTouched();                           //this should not be necessary!
-    return App::DocumentObject::StdReturn;
+    return App::DocumentObject::execute();
 }
 
 void DrawView::checkScale(void)
@@ -140,8 +126,8 @@ void DrawView::checkScale(void)
 void DrawView::onChanged(const App::Property* prop)
 {
 //Coding note: calling execute, recompute or recomputeFeature inside an onChanged
-//method can create infinite loops.  In general don't do this!  There may be 
-//situations where it is OK, but careful analysis is a must. 
+//method can create infinite loops if the called method changes a property.  In general
+//don't do this!  There are situations where it is OK, but careful analysis is a must.
     if (!isRestoring()) {
         if (prop == &ScaleType) {
             auto page = findParentPage();
@@ -173,6 +159,7 @@ void DrawView::onChanged(const App::Property* prop)
             requestPaint();
         } else if ((prop == &X) ||
             (prop == &Y)) {
+            DrawView::execute();
             X.purgeTouched();
             Y.purgeTouched();
         }
diff --git a/src/Mod/TechDraw/App/DrawView.h b/src/Mod/TechDraw/App/DrawView.h
index 5cfe062ad9..f60534e4b1 100644
--- a/src/Mod/TechDraw/App/DrawView.h
+++ b/src/Mod/TechDraw/App/DrawView.h
@@ -66,7 +66,6 @@ public:
     /** @name methods override Feature */
     //@{
     /// recalculate the Feature
-    virtual App::DocumentObjectExecReturn *recompute() override;
     virtual App::DocumentObjectExecReturn *execute(void) override;
     virtual void onDocumentRestored() override;
     virtual short mustExecute() const override;