kindred/create
1
1
Fork 0
Code Issues 44 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

App: Fix crash and undefined behavior in StringHasherPy and StringIDPy

Browse Source
This commit is contained in:
marioalexis
2023-08-07 22:31:56 -03:00
parent 818a4f1cc8
commit cd521d77eb
2 changed files with 62 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/App/StringIDPyImp.cpp
View File

@@ -38,13 +38,15 @@ std::string StringIDPy::representation() const
PyObject* StringIDPy::isSame(PyObject *args)
{
PyObject *other = nullptr;
if (PyArg_ParseTuple(args, "O!", &StringIDPy::Type, &other) == 0) { // convert args: Python->C
return Py::new_reference_to(Py::False());
if (!PyArg_ParseTuple(args, "O!", &StringIDPy::Type, &other)) {
return nullptr;
}
auto *otherPy = static_cast<StringIDPy*>(other);
return Py::new_reference_to(Py::Boolean(
otherPy->getStringIDPtr() == this->getStringIDPtr()
&& otherPy->_index == this->_index));
bool same = (otherPy->getStringIDPtr() == this->getStringIDPtr())
&& (otherPy->_index == this->_index);
return PyBool_FromLong(same ? 1 : 0);
}
Py::Int StringIDPy::getValue() const {