kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Surface: Fix several clazy issues:

Browse Source 
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* Use multi-arg instead [-Wclazy-qstring-arg]
This commit is contained in:
wmayer
2022-07-25 10:01:49 +02:00
parent 8444484677
commit cea60a2cb4
8 changed files with 49 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/Mod/Surface/Gui/TaskFillingVertex.cpp
View File

@@ -96,9 +96,9 @@ private:
return false;
auto links = editedObject->Points.getSubListValues();
for (auto it : links) {
for (const auto& it : links) {
if (it.first == pObj) {
for (auto jt : it.second) {
for (const auto& jt : it.second) {
if (jt == sSubName)
return !appendVertex;
}
@@ -160,8 +160,8 @@ void FillingVertexPanel::setEditedObject(Surface::Filling* obj)
ui->listFreeVertex->addItem(item);
QString text = QString::fromLatin1("%1.%2")
.arg(QString::fromUtf8((*it)->Label.getValue()))
.arg(QString::fromStdString(*jt));
.arg(QString::fromUtf8((*it)->Label.getValue()),
QString::fromStdString(*jt));
item->setText(text);
QList<QVariant> data;
@@ -259,8 +259,8 @@ void FillingVertexPanel::onSelectionChanged(const Gui::SelectionChanges& msg)
Gui::SelectionObject sel(msg);
QString text = QString::fromLatin1("%1.%2")
.arg(QString::fromUtf8(sel.getObject()->Label.getValue()))
.arg(QString::fromLatin1(msg.pSubName));
.arg(QString::fromUtf8(sel.getObject()->Label.getValue()),
QString::fromLatin1(msg.pSubName));
item->setText(text);
QList<QVariant> data;