Clang: fix clang-diagnostic-error

2022-08-24 17:02:17 +02:00
parent 180edfa3cc
commit ced0f46ef5
3 changed files with 11 additions and 3 deletions
--- a/src/Mod/Part/App/TopoShape.cpp
+++ b/src/Mod/Part/App/TopoShape.cpp
@@ -2015,10 +2015,13 @@ TopoDS_Shape TopoShape::makePipeShell(const TopTools_ListOfShape& profiles,
        mkPipeShell.Add(TopoDS_Shape(it.Value()));
    }

-    if (!mkPipeShell.IsReady()) Standard_Failure::Raise("shape is not ready to build");
-    else mkPipeShell.Build();
+    if (!mkPipeShell.IsReady())
+        throw Standard_Failure("shape is not ready to build");

-    if (make_solid)	mkPipeShell.MakeSolid();
+    mkPipeShell.Build();
+
+    if (make_solid)
+        mkPipeShell.MakeSolid();

    return mkPipeShell.Shape();
 }