From cfabcbe9d58ba594799f100bef3e76775fa8cb49 Mon Sep 17 00:00:00 2001 From: Chris Hennes Date: Thu, 17 Feb 2022 11:33:52 -0600 Subject: [PATCH] TD: Fix MSVC compilation failure Also shifts to snprintf to eliminate overrun risk. --- src/Mod/TechDraw/Gui/TaskCustomizeFormat.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Mod/TechDraw/Gui/TaskCustomizeFormat.cpp b/src/Mod/TechDraw/Gui/TaskCustomizeFormat.cpp index 3ab2e33677..0e9b7b71b0 100644 --- a/src/Mod/TechDraw/Gui/TaskCustomizeFormat.cpp +++ b/src/Mod/TechDraw/Gui/TaskCustomizeFormat.cpp @@ -202,11 +202,11 @@ void TaskCustomizeFormat::onFormatChanged() QString formatPreview = ui->leFormat->text(); if (isDimension) { - int size(80); + constexpr int size(80); char buffer[size]; std::string formatString = formatPreview.toUtf8().constData(); - size = sprintf(buffer,formatString.c_str(),dimRawValue); - formatPreview = QString::fromUtf8(buffer,size); + auto usedSize = snprintf(buffer,size, formatString.c_str(),dimRawValue); + formatPreview = QString::fromUtf8(buffer, usedSize); } ui->lbShowPreview->setText(formatPreview); }