diff --git a/src/Mod/MeshPart/App/AppMeshPartPy.cpp b/src/Mod/MeshPart/App/AppMeshPartPy.cpp index c221a93073..f216c22dd7 100644 --- a/src/Mod/MeshPart/App/AppMeshPartPy.cpp +++ b/src/Mod/MeshPart/App/AppMeshPartPy.cpp @@ -272,7 +272,7 @@ private: proj.projectToMesh(shape, maxDist, polylines); Py::List list; - for (auto it : polylines) { + for (const auto& it : polylines) { Py::List poly; for (auto jt : it.points) { Py::Vector v(jt); @@ -304,7 +304,7 @@ private: std::vector polylines; proj.projectParallelToMesh(shape, dir, polylines); Py::List list; - for (auto it : polylines) { + for (const auto& it : polylines) { Py::List poly; for (auto jt : it.points) { Py::Vector v(jt); @@ -354,7 +354,7 @@ private: proj.projectParallelToMesh(polylinesIn, dir, polylines); Py::List list; - for (auto it : polylines) { + for (const auto& it : polylines) { Py::List poly; for (auto jt : it.points) { Py::Vector v(jt); diff --git a/src/Mod/MeshPart/App/CurveProjector.cpp b/src/Mod/MeshPart/App/CurveProjector.cpp index 5731521aa3..6091401bdc 100644 --- a/src/Mod/MeshPart/App/CurveProjector.cpp +++ b/src/Mod/MeshPart/App/CurveProjector.cpp @@ -785,7 +785,7 @@ void MeshProjection::findSectionParameters(const TopoDS_Edge& edge, const Base:: const MeshCore::MeshPointArray& points = _rcMesh.GetPoints(); Base::Vector3f res; - for (auto it : facets) { + for (const auto& it : facets) { for (int i=0; i<3; i++) { Base::Vector3f pt1 = points[it._aulPoints[i]]; Base::Vector3f pt2 = points[it._aulPoints[(i+1)%3]]; @@ -860,7 +860,7 @@ void MeshProjection::projectOnMesh(const std::vector& pointsIn, const MeshCore::MeshFacetArray& facets = _rcMesh.GetFacets(); const MeshCore::MeshPointArray& points = _rcMesh.GetPoints(); - for (auto it : facets) { + for (const auto& it : facets) { for (int i=0; i<3; i++) { if (!it.HasNeighbour(i)) { boundaryPoints.push_back(points[it._aulPoints[i]]); @@ -985,7 +985,7 @@ void MeshProjection::projectParallelToMesh (const std::vector &aEdges, Base::SequencerLauncher seq( "Project curve on mesh", aEdges.size() ); - for (auto it : aEdges) { + for (const auto& it : aEdges) { std::vector points = it.points; typedef std::pair HitPoint; diff --git a/src/Mod/MeshPart/App/Mesher.cpp b/src/Mod/MeshPart/App/Mesher.cpp index bc86eecfbd..7f3615a971 100644 --- a/src/Mod/MeshPart/App/Mesher.cpp +++ b/src/Mod/MeshPart/App/Mesher.cpp @@ -177,7 +177,7 @@ public: MeshCore::MeshFacetArray faces; std::size_t numTriangles = 0; - for (auto it : domains) + for (const auto& it : domains) numTriangles += it.facets.size(); faces.reserve(numTriangles); @@ -265,7 +265,7 @@ public: MeshCore::MeshPointArray verts; verts.resize(vertices.size()); - for (auto it : vertices) + for (const auto& it : vertices) verts[it.i] = it.toPoint(); MeshCore::MeshKernel kernel; @@ -275,7 +275,7 @@ public: meshdata->swap(kernel); if (createSegm) { int index = 0; - for (auto it : colorMap) { + for (const auto& it : colorMap) { Mesh::Segment segm(meshdata, false); for (auto jt : it.second) { segm.addIndices(meshSegments[jt]); @@ -291,7 +291,7 @@ public: } } else { - for (auto it : meshSegments) { + for (const auto& it : meshSegments) { meshdata->addSegment(it); } } diff --git a/src/Mod/MeshPart/Gui/Command.cpp b/src/Mod/MeshPart/Gui/Command.cpp index f91ff09030..39ce6be39a 100644 --- a/src/Mod/MeshPart/Gui/Command.cpp +++ b/src/Mod/MeshPart/Gui/Command.cpp @@ -229,8 +229,8 @@ void CmdMeshPartSection::activated(int) std::vector polylines; mesh->crossSections(sections, polylines); - for (auto it2 : polylines) { - for (auto it3 : it2) { + for (const auto& it2 : polylines) { + for (const auto& it3 : it2) { Py::Tuple arg(1); Py::List list; for (auto it4 : it3) { diff --git a/src/Mod/MeshPart/Gui/Tessellation.cpp b/src/Mod/MeshPart/Gui/Tessellation.cpp index a0f5ac1bc1..72d13ef06b 100644 --- a/src/Mod/MeshPart/Gui/Tessellation.cpp +++ b/src/Mod/MeshPart/Gui/Tessellation.cpp @@ -307,11 +307,11 @@ void Tessellation::process(int method, App::Document* doc, const std::listdocument) - .arg(objname) - .arg(subname) - .arg(param) - .arg(label); + .arg(this->document, + objname, + subname, + param, + label); Gui::Command::runCommand(Gui::Command::Doc, cmd.toUtf8());