kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Gui: [skip ci] Coverity: Uncaught exception

Browse Source
This commit is contained in:
wmayer
2020-09-14 17:21:50 +02:00
parent 1c9573e8d2
commit d16c35a17d
1 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/Gui/View3DInventorViewer.cpp
View File

@@ -1085,17 +1085,30 @@ void View3DInventorViewer::resetEditingRoot(bool updateLinks)
ViewProviderLink::updateLinks(editViewProvider);
}
catch (const Py::Exception& e) {
Py::Object o = Py::type(e);
if (o.isString()) {
Py::String s(o);
Base::Console().Warning("%s\n", s.as_std_string("utf-8").c_str());
/* coverity[UNCAUGHT_EXCEPT] Uncaught exception */
// Coverity created several reports when removeViewProvider()
// is used somewhere in a destructor which indirectly invokes
// resetEditingRoot().
// Now theoretically Py::type can throw an exception which nowhere
// will be handled and thus terminates the application. So, add an
// extra try/catch block here.
try {
Py::Object o = Py::type(e);
if (o.isString()) {
Py::String s(o);
Base::Console().Warning("%s\n", s.as_std_string("utf-8").c_str());
}
else {
Py::String s(o.repr());
Base::Console().Warning("%s\n", s.as_std_string("utf-8").c_str());
}
// Prints message to console window if we are in interactive mode
PyErr_Print();
}
else {
Py::String s(o.repr());
Base::Console().Warning("%s\n", s.as_std_string("utf-8").c_str());
catch (Py::Exception& e) {
e.clear();
Base::Console().Error("Unexpected exception raised in View3DInventorViewer::resetEditingRoot\n");
}
// Prints message to console window if we are in interactive mode
PyErr_Print();
}
}