From d1dae5af1ce5bc7e4cc11164728ac80bdffd0139 Mon Sep 17 00:00:00 2001
From: marioalexis <mario.passaglia@gmail.com>
Date: Mon, 8 Sep 2025 20:09:33 -0300
Subject: [PATCH] Fem: Fix Gmsh preferences file chooser

---
 src/Mod/Fem/Gui/DlgSettingsFemGmsh.ui     |  2 +-
 src/Mod/Fem/Gui/DlgSettingsFemGmshImp.cpp | 11 +++--------
 src/Mod/Fem/Gui/DlgSettingsFemGmshImp.h   |  2 +-
 3 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/src/Mod/Fem/Gui/DlgSettingsFemGmsh.ui b/src/Mod/Fem/Gui/DlgSettingsFemGmsh.ui
index 1549fbe5cd..fd3d875ef7 100644
--- a/src/Mod/Fem/Gui/DlgSettingsFemGmsh.ui
+++ b/src/Mod/Fem/Gui/DlgSettingsFemGmsh.ui
@@ -86,7 +86,7 @@
            </size>
           </property>
           <property name="text">
-           <string>Gmsh binary path</string>
+           <string>Gmsh path</string>
           </property>
          </widget>
         </item>
diff --git a/src/Mod/Fem/Gui/DlgSettingsFemGmshImp.cpp b/src/Mod/Fem/Gui/DlgSettingsFemGmshImp.cpp
index aa51594c4a..dc907b8340 100644
--- a/src/Mod/Fem/Gui/DlgSettingsFemGmshImp.cpp
+++ b/src/Mod/Fem/Gui/DlgSettingsFemGmshImp.cpp
@@ -83,15 +83,10 @@ void DlgSettingsFemGmshImp::changeEvent(QEvent* e)
     }
 }
 
-void DlgSettingsFemGmshImp::onfileNameSelected(QString FileName)
+void DlgSettingsFemGmshImp::onfileNameSelected(const QString& fileName)
 {
-    if (!FileName.isEmpty() && QStandardPaths::findExecutable(FileName).isEmpty()) {
-        QMessageBox::critical(
-            this,
-            tr("Not an executable binary"),
-            tr("The specified file \n'%1'\n does not exist or is not executable.\n"
-               "Specify another file.")
-                .arg(FileName));
+    if (!fileName.isEmpty() && QStandardPaths::findExecutable(fileName).isEmpty()) {
+        QMessageBox::critical(this, tr("Gmsh"), tr("Executable '%1' not found").arg(fileName));
     }
 }
 
diff --git a/src/Mod/Fem/Gui/DlgSettingsFemGmshImp.h b/src/Mod/Fem/Gui/DlgSettingsFemGmshImp.h
index aeb5737b4b..a9e3cd5843 100644
--- a/src/Mod/Fem/Gui/DlgSettingsFemGmshImp.h
+++ b/src/Mod/Fem/Gui/DlgSettingsFemGmshImp.h
@@ -41,7 +41,7 @@ public:
     ~DlgSettingsFemGmshImp() override;
 
 protected Q_SLOTS:
-    void onfileNameSelected(QString FileName);
+    void onfileNameSelected(const QString& fileName);
 
 protected:
     void saveSettings() override;