From d4e8a5a384fb08de5f2bf2a1fecbcd23e6442de4 Mon Sep 17 00:00:00 2001 From: wmayer Date: Fri, 12 Feb 2021 16:55:39 +0100 Subject: [PATCH] TechDraw: [skip ci] avoid to trigger a slot in constructor of TaskBalloon --- src/Mod/TechDraw/Gui/TaskBalloon.cpp | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/Mod/TechDraw/Gui/TaskBalloon.cpp b/src/Mod/TechDraw/Gui/TaskBalloon.cpp index d092c8a721..d3e2821054 100644 --- a/src/Mod/TechDraw/Gui/TaskBalloon.cpp +++ b/src/Mod/TechDraw/Gui/TaskBalloon.cpp @@ -89,15 +89,13 @@ TaskBalloon::TaskBalloon(QGIViewBalloon *parent, ViewProviderBalloon *balloonVP) ui->qsbFontSize->setUnit(Base::Unit::Length); ui->qsbFontSize->setMinimum(0); - connect(ui->qsbFontSize, SIGNAL(valueChanged(double)), this, SLOT(onFontsizeChanged())); - connect(ui->comboLineVisible, SIGNAL(currentIndexChanged(int)), this, SLOT(onLineVisibleChanged())); + ui->qsbLineWidth->setUnit(Base::Unit::Length); ui->qsbLineWidth->setSingleStep(0.100); ui->qsbLineWidth->setMinimum(0); - connect(ui->qsbLineWidth, SIGNAL(valueChanged(double)), this, SLOT(onLineWidthChanged())); - ui->qsbKinkLength->setUnit(Base::Unit::Length); + // negative kink length is allowed, thus no minimum - connect(ui->qsbKinkLength, SIGNAL(valueChanged(double)), this, SLOT(onKinkLengthChanged())); + ui->qsbKinkLength->setUnit(Base::Unit::Length); if (balloonVP != nullptr) { ui->textColor->setColor(balloonVP->Color.getValue().asValue()); @@ -108,6 +106,11 @@ TaskBalloon::TaskBalloon(QGIViewBalloon *parent, ViewProviderBalloon *balloonVP) } // new balloons have already the preferences BalloonKink length ui->qsbKinkLength->setValue(parent->dvBalloon->KinkLength.getValue()); + + connect(ui->qsbFontSize, SIGNAL(valueChanged(double)), this, SLOT(onFontsizeChanged())); + connect(ui->comboLineVisible, SIGNAL(currentIndexChanged(int)), this, SLOT(onLineVisibleChanged())); + connect(ui->qsbLineWidth, SIGNAL(valueChanged(double)), this, SLOT(onLineWidthChanged())); + connect(ui->qsbKinkLength, SIGNAL(valueChanged(double)), this, SLOT(onKinkLengthChanged())); } TaskBalloon::~TaskBalloon()