+ move creation of SoFCSelection node to ViewProviderBuilder to avoid code duplication

src/Gui/ViewProviderBuilder.cpp

@@ -28,6 +28,8 @@
 #endif
 
 #include "ViewProviderBuilder.h"
+#include "SoFCSelection.h"
+#include "Window.h"
 #include <App/PropertyStandard.h>
 
 using namespace Gui;
@@ -55,6 +57,40 @@ ViewProvider* ViewProviderBuilder::create(const Base::Type& type)
     return 0;
 }
 
+Gui::SoFCSelection* ViewProviderBuilder::createSelection()
+{
+    Gui::SoFCSelection* sel = new Gui::SoFCSelection();
+
+    float transparency;
+    ParameterGrp::handle hGrp = Gui::WindowParameter::getDefaultParameter()->GetGroup("View");
+    bool enablePre = hGrp->GetBool("EnablePreselection", true);
+    bool enableSel = hGrp->GetBool("EnableSelection", true);
+    if (!enablePre) {
+        sel->highlightMode = Gui::SoFCSelection::OFF;
+    }
+    else {
+        // Search for a user defined value with the current color as default
+        SbColor highlightColor = sel->colorHighlight.getValue();
+        unsigned long highlight = (unsigned long)(highlightColor.getPackedValue());
+        highlight = hGrp->GetUnsigned("HighlightColor", highlight);
+        highlightColor.setPackedValue((uint32_t)highlight, transparency);
+        sel->colorHighlight.setValue(highlightColor);
+    }
+    if (!enableSel) {
+        sel->selectionMode = Gui::SoFCSelection::SEL_OFF;
+    }
+    else {
+        // Do the same with the selection color
+        SbColor selectionColor = sel->colorSelection.getValue();
+        unsigned long selection = (unsigned long)(selectionColor.getPackedValue());
+        selection = hGrp->GetUnsigned("SelectionColor", selection);
+        selectionColor.setPackedValue((uint32_t)selection, transparency);
+        sel->colorSelection.setValue(selectionColor);
+    }
+
+    return sel;
+}
+
 // --------------------------------------
 
 ViewProviderColorBuilder::ViewProviderColorBuilder() 

src/Gui/ViewProviderBuilder.h

@@ -40,6 +40,7 @@ namespace Gui
 {
 
 class ViewProvider;
+class SoFCSelection;
 class GuiExport ViewProviderBuilder
 {
 public:
@@ -50,6 +51,7 @@ public:
 
     static void add(const Base::Type&, const Base::Type&);
     static ViewProvider* create(const Base::Type&);
+    static SoFCSelection* createSelection();
 
 private:
     static std::map<Base::Type, Base::Type> _prop_to_view;