kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

fix (Qt) issues found by clang's clazy tool:

Browse Source 
+ -Wclazy-incorrect-emit
+ -Wclazy-strict-iterators
+ -Wclazy-overloaded-signal
+ -Wclazy-qstring-arg
+ -Wclazy-unused-non-trivial-variable
+ -Wclazy-container-anti-pattern
+ -Wclazy-range-loop-reference
+ -Wclazy-const-signal-or-slot
+ -Wclazy-detaching-temporary
+ -Wclazy-qfileinfo-exists
This commit is contained in:
wmayer
2022-06-29 21:00:54 +02:00
parent 898b1007b9
commit d5921e08ec
49 changed files with 185 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Gui/DockWindowManager.cpp
View File

@@ -171,7 +171,7 @@ QDockWidget* DockWindowManager::addDockWindow(const char* name, QWidget* widget,
*/
QWidget* DockWindowManager::getDockWindow(const char* name) const
{
for (QList<QDockWidget*>::ConstIterator it = d->_dockedWindows.begin(); it != d->_dockedWindows.end(); ++it) {
for (QList<QDockWidget*>::Iterator it = d->_dockedWindows.begin(); it != d->_dockedWindows.end(); ++it) {
if ((*it)->objectName() == QLatin1String(name))
return (*it)->widget();
}
@@ -185,7 +185,7 @@ QWidget* DockWindowManager::getDockWindow(const char* name) const
QList<QWidget*> DockWindowManager::getDockWindows() const
{
QList<QWidget*> docked;
for (QList<QDockWidget*>::ConstIterator it = d->_dockedWindows.begin(); it != d->_dockedWindows.end(); ++it)
for (QList<QDockWidget*>::Iterator it = d->_dockedWindows.begin(); it != d->_dockedWindows.end(); ++it)
docked.push_back((*it)->widget());
return docked;
}
@@ -334,7 +334,7 @@ void DockWindowManager::setup(DockWindowItems* items)
bool visible = hPref->GetBool(dockName.constData(), it->visibility);
if (!dw) {
QMap<QString, QPointer<QWidget> >::ConstIterator jt = d->_dockWindows.find(it->name);
QMap<QString, QPointer<QWidget> >::Iterator jt = d->_dockWindows.find(it->name);
if (jt != d->_dockWindows.end()) {
dw = addDockWindow(jt.value()->objectName().toUtf8(), jt.value(), it->pos);
jt.value()->show();