kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

fix (Qt) issues found by clang's clazy tool:

Browse Source 
+ -Wclazy-incorrect-emit
+ -Wclazy-strict-iterators
+ -Wclazy-overloaded-signal
+ -Wclazy-qstring-arg
+ -Wclazy-unused-non-trivial-variable
+ -Wclazy-container-anti-pattern
+ -Wclazy-range-loop-reference
+ -Wclazy-const-signal-or-slot
+ -Wclazy-detaching-temporary
+ -Wclazy-qfileinfo-exists
This commit is contained in:
wmayer
2022-06-29 21:00:54 +02:00
parent 898b1007b9
commit d5921e08ec
49 changed files with 185 additions and 180 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Gui/ToolBoxManager.cpp
View File

@@ -83,7 +83,7 @@ void ToolBoxManager::setup( ToolBarItem* toolBar ) const
CommandManager& mgr = Application::Instance->commandManager();
QList<ToolBarItem*> items = toolBar->getItems();
for ( QList<ToolBarItem*>::ConstIterator item = items.begin(); item != items.end(); ++item )
for ( QList<ToolBarItem*>::Iterator item = items.begin(); item != items.end(); ++item )
{
QToolBar* bar = new QToolBar();
bar->setOrientation(Qt::Vertical);
@@ -94,7 +94,7 @@ void ToolBoxManager::setup( ToolBarItem* toolBar ) const
_toolBox->addItem( bar, bar->windowTitle() );
QList<ToolBarItem*> subitems = (*item)->getItems();
for ( QList<ToolBarItem*>::ConstIterator subitem = subitems.begin(); subitem != subitems.end(); ++subitem )
for ( QList<ToolBarItem*>::Iterator subitem = subitems.begin(); subitem != subitems.end(); ++subitem )
{
if ( (*subitem)->command() == "Separator" ) {
//bar->addSeparator();