From d618efe2e70714c08339ada5f2d8f75629bcb0c6 Mon Sep 17 00:00:00 2001 From: Benjamin Nauck Date: Mon, 19 May 2025 19:52:20 +0200 Subject: [PATCH] Base: Skip test for units using GTEST_SKIP() instead of comments --- tests/src/Base/SchemaTests.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/src/Base/SchemaTests.cpp b/tests/src/Base/SchemaTests.cpp index e6ca6f5fca..0b170fa9be 100644 --- a/tests/src/Base/SchemaTests.cpp +++ b/tests/src/Base/SchemaTests.cpp @@ -315,18 +315,16 @@ TEST_F(SchemaTest, imperial_building_special_function_length_foot) EXPECT_EQ(result, expect); } -/* - * QuantityParser::yyparse() is crashing on the >>1' 2" + 1/4"<< input, - * so disable this test TEST_F(SchemaTest, imperial_building_special_function_length) { + GTEST_SKIP() << "QuantityParser::yyparse() is crashing on the >>1' 2\" + 1/4\"<< input, " + "so disable this test"; constexpr auto val {360.6}; const auto result = set("ImperialBuilding", Unit::Length, val); const auto expect = Tools::escapeQuotesFromString("1' 2\" + 1/4\""); EXPECT_EQ(result, expect); } -*/ TEST_F(SchemaTest, imperial_building_special_function_length_neg) {