From d767a923a39d4a9bd8a0e248981e8b83fe12984f Mon Sep 17 00:00:00 2001 From: Chris Hennes Date: Mon, 7 Nov 2022 13:55:31 -0600 Subject: [PATCH] Addon Manager: Add try/except to integer conversion --- src/Mod/AddonManager/NetworkManager.py | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/Mod/AddonManager/NetworkManager.py b/src/Mod/AddonManager/NetworkManager.py index 9c80c8443b..ec542f21be 100644 --- a/src/Mod/AddonManager/NetworkManager.py +++ b/src/Mod/AddonManager/NetworkManager.py @@ -212,7 +212,17 @@ if HAVE_QTNETWORK: ) # This may still be QNetworkProxy.NoProxy elif userProxyCheck: host, _, port_string = proxy_string.rpartition(":") - port = 0 if not port_string else int(port_string) + try: + port = 0 if not port_string else int(port_string) + except ValueError: + FreeCAD.Console.PrintError( + translate( + "AddonsInstaller", + "Failed to convert the specified proxy port '{}' to a port number", + ).format(port_string) + + "\n" + ) + port = 0 # For now assume an HttpProxy, but eventually this should be a parameter proxy = QtNetwork.QNetworkProxy( QtNetwork.QNetworkProxy.HttpProxy, host, port