kindred/create
1
1
Fork 0
Code Issues 51 Pull Requests 1 Actions Packages Projects 9 Releases 2 Wiki Activity

App: fix Python object leak in ObjectIdentifier

Browse Source
This commit is contained in:
Zheng, Lei
2019-08-27 08:29:54 +08:00
committed by wmayer
parent bfca168ab7
commit d967e86fcc
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/App/ObjectIdentifier.cpp
View File

@@ -614,7 +614,7 @@ Py::Object ObjectIdentifier::Component::get(const Py::Object &pyobj) const {
assert(isRange());
Py::Object slice(PySlice_New(Py::Int(begin).ptr(),
end!=INT_MAX?Py::Int(end).ptr():0,
step!=1?Py::Int(step).ptr():0));
step!=1?Py::Int(step).ptr():0),true);
PyObject *r = PyObject_GetItem(pyobj.ptr(),slice.ptr());
if(!r)
Base::PyException::ThrowException();
@@ -640,7 +640,7 @@ void ObjectIdentifier::Component::set(Py::Object &pyobj, const Py::Object &value
assert(isRange());
Py::Object slice(PySlice_New(Py::Int(begin).ptr(),
end!=INT_MAX?Py::Int(end).ptr():0,
step!=1?Py::Int(step).ptr():0));
step!=1?Py::Int(step).ptr():0),true);
if(PyObject_SetItem(pyobj.ptr(),slice.ptr(),value.ptr())<0)
Base::PyException::ThrowException();
}
@@ -660,7 +660,7 @@ void ObjectIdentifier::Component::del(Py::Object &pyobj) const {
assert(isRange());
Py::Object slice(PySlice_New(Py::Int(begin).ptr(),
end!=INT_MAX?Py::Int(end).ptr():0,
step!=1?Py::Int(step).ptr():0));
step!=1?Py::Int(step).ptr():0),true);
if(PyObject_DelItem(pyobj.ptr(),slice.ptr())<0)
Base::PyException::ThrowException();
}