+ fixes #0002075: Analysis of FreeCAD by PVS-Studio static analyzer

2015-05-01 16:56:31 +02:00
parent d8f63bcfd1
commit dd2b39ddd6
21 changed files with 59 additions and 91 deletions
--- a/src/Gui/View3DInventorExamples.cpp
+++ b/src/Gui/View3DInventorExamples.cpp
@@ -290,8 +290,8 @@ void LightManip(SoSeparator * root)
  SoInput in;
  in.setBuffer((void *)scenegraph, std::strlen(scenegraph));
  SoSeparator * _root = SoDB::readAll( &in );
+  if ( _root == NULL ) return; // Shouldn't happen.
  root->addChild(_root);
-  if ( root == NULL ) return; // Shouldn't happen.
  root->ref();

  const char * pointlightnames[3] = { "RedLight", "GreenLight", "BlueLight" };