+ fixes #0002075: Analysis of FreeCAD by PVS-Studio static analyzer

2015-05-01 16:56:31 +02:00
parent d8f63bcfd1
commit dd2b39ddd6
21 changed files with 59 additions and 91 deletions
--- a/src/Mod/Fem/Gui/ViewProviderFemMesh.cpp
+++ b/src/Mod/Fem/Gui/ViewProviderFemMesh.cpp
@@ -689,9 +689,10 @@ void ViewProviderFEMMeshBuilder::buildNodes(const App::Property* prop, std::vect

 inline void insEdgeVec(std::map<int,std::set<int> > &map, int n1, int n2)
 {
-    if(n1<n2)
-        map[n2].insert(n1);
-    else
+    //FIXME: The if-else distinction doesn't make sense
+    //if (n1<n2)
+    //    map[n2].insert(n1);
+    //else
        map[n2].insert(n1);
 };