kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PD: improve task panel for polar patterns:

Browse Source 
* set range of Occurrences property to spin box
* connect signals after initializing widgets to avoid superfluous recomputes and possible inconsistencies
This commit is contained in:
wmayer
2021-03-03 10:32:46 +01:00
parent 7b43f7e996
commit dd31be3b19
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/Mod/PartDesign/Gui/TaskPolarPatternParameters.cpp
View File

@@ -103,7 +103,7 @@ TaskPolarPatternParameters::TaskPolarPatternParameters(TaskMultiTransformParamet
setupUI();
}
void TaskPolarPatternParameters::setupUI()
void TaskPolarPatternParameters::connectSignals()
{
connect(ui->buttonAddFeature, SIGNAL(toggled(bool)), this, SLOT(onButtonAddFeature(bool)));
connect(ui->buttonRemoveFeature, SIGNAL(toggled(bool)), this, SLOT(onButtonRemoveFeature(bool)));
@@ -121,9 +121,6 @@ void TaskPolarPatternParameters::setupUI()
connect(ui->listWidgetFeatures->model(),
SIGNAL(rowsMoved(QModelIndex, int, int, QModelIndex, int)), this, SLOT(indexesMoved()));
ui->spinOccurrences->setMaximum(INT_MAX);
ui->spinOccurrences->setMinimum(1);
updateViewTimer = new QTimer(this);
updateViewTimer->setSingleShot(true);
updateViewTimer->setInterval(getUpdateViewTimeout());
@@ -140,7 +137,10 @@ void TaskPolarPatternParameters::setupUI()
this, SLOT(onOccurrences(uint)));
connect(ui->checkBoxUpdateView, SIGNAL(toggled(bool)),
this, SLOT(onUpdateView(bool)));
}
void TaskPolarPatternParameters::setupUI()
{
// Get the feature data
PartDesign::PolarPattern* pcPolarPattern = static_cast<PartDesign::PolarPattern*>(getObject());
std::vector<App::DocumentObject*> originals = pcPolarPattern->Originals.getValues();
@@ -159,6 +159,8 @@ void TaskPolarPatternParameters::setupUI()
ui->polarAngle->bind(pcPolarPattern->Angle);
ui->spinOccurrences->bind(pcPolarPattern->Occurrences);
ui->spinOccurrences->setMaximum(pcPolarPattern->Occurrences.getMaximum());
ui->spinOccurrences->setMinimum(pcPolarPattern->Occurrences.getMinimum());
ui->comboAxis->setEnabled(true);
ui->checkReverse->setEnabled(true);
@@ -189,6 +191,7 @@ void TaskPolarPatternParameters::setupUI()
}
updateUI();
connectSignals();
}
void TaskPolarPatternParameters::updateUI()