kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Prefer to use BaseClass's isDerivedFrom<T> over non template or Base::Type's

Browse Source 
Regex based changes, manually verified
This commit is contained in:
Benjamin Nauck
2025-01-16 21:27:50 +01:00
parent ae15d98fd3
commit dd6aa9f3c7
166 changed files with 484 additions and 497 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/Mod/TechDraw/App/DrawViewDimension.cpp
View File

@@ -809,7 +809,7 @@ pointPair DrawViewDimension::getPointsOneEdge(ReferenceVector references)
{
App::DocumentObject* refObject = references.front().getObject();
int iSubelement = DrawUtil::getIndexFromName(references.front().getSubName());
if (refObject->isDerivedFrom(TechDraw::DrawViewPart::getClassTypeId())
if (refObject->isDerivedFrom<TechDraw::DrawViewPart>()
&& !references.at(0).getSubName().empty()) {
// TODO: Notify if not straight line Edge?
// this is a 2d object (a DVP + subelements)
@@ -850,7 +850,7 @@ pointPair DrawViewDimension::getPointsTwoEdges(ReferenceVector references)
App::DocumentObject* refObject = references.front().getObject();
int iSubelement0 = DrawUtil::getIndexFromName(references.at(0).getSubName());
int iSubelement1 = DrawUtil::getIndexFromName(references.at(1).getSubName());
if (refObject->isDerivedFrom(TechDraw::DrawViewPart::getClassTypeId())
if (refObject->isDerivedFrom<TechDraw::DrawViewPart>()
&& !references.at(0).getSubName().empty()) {
// this is a 2d object (a DVP + subelements)
TechDraw::BaseGeomPtr geom0 = getViewPart()->getGeomByIndex(iSubelement0);
@@ -882,7 +882,7 @@ pointPair DrawViewDimension::getPointsTwoVerts(ReferenceVector references)
App::DocumentObject* refObject = references.front().getObject();
int iSubelement0 = DrawUtil::getIndexFromName(references.at(0).getSubName());
int iSubelement1 = DrawUtil::getIndexFromName(references.at(1).getSubName());
if (refObject->isDerivedFrom(TechDraw::DrawViewPart::getClassTypeId())
if (refObject->isDerivedFrom<TechDraw::DrawViewPart>()
&& !references.at(0).getSubName().empty()) {
// this is a 2d object (a DVP + subelements)
TechDraw::VertexPtr v0 = getViewPart()->getProjVertexByIndex(iSubelement0);
@@ -919,7 +919,7 @@ pointPair DrawViewDimension::getPointsEdgeVert(ReferenceVector references)
App::DocumentObject* refObject = references.front().getObject();
int iSubelement0 = DrawUtil::getIndexFromName(references.at(0).getSubName());
int iSubelement1 = DrawUtil::getIndexFromName(references.at(1).getSubName());
if (refObject->isDerivedFrom(TechDraw::DrawViewPart::getClassTypeId())
if (refObject->isDerivedFrom<TechDraw::DrawViewPart>()
&& !references.at(0).getSubName().empty()) {
// this is a 2d object (a DVP + subelements)
TechDraw::BaseGeomPtr edge;
@@ -975,7 +975,7 @@ arcPoints DrawViewDimension::getArcParameters(ReferenceVector references)
{
App::DocumentObject* refObject = references.front().getObject();
int iSubelement = DrawUtil::getIndexFromName(references.front().getSubName());
if (refObject->isDerivedFrom(TechDraw::DrawViewPart::getClassTypeId())
if (refObject->isDerivedFrom<TechDraw::DrawViewPart>()
&& !references.at(0).getSubName().empty()) {
// this is a 2d object (a DVP + subelements)
TechDraw::BaseGeomPtr geom = getViewPart()->getGeomByIndex(iSubelement);
@@ -1207,7 +1207,7 @@ anglePoints DrawViewDimension::getAnglePointsTwoEdges(ReferenceVector references
App::DocumentObject* refObject = references.front().getObject();
int iSubelement0 = DrawUtil::getIndexFromName(references.at(0).getSubName());
int iSubelement1 = DrawUtil::getIndexFromName(references.at(1).getSubName());
if (refObject->isDerivedFrom(TechDraw::DrawViewPart::getClassTypeId())
if (refObject->isDerivedFrom<TechDraw::DrawViewPart>()
&& !references.at(0).getSubName().empty()) {
// this is a 2d object (a DVP + subelements)
TechDraw::BaseGeomPtr geom0 = getViewPart()->getGeomByIndex(iSubelement0);
@@ -1345,7 +1345,7 @@ anglePoints DrawViewDimension::getAnglePointsThreeVerts(ReferenceVector referenc
int iSubelement0 = DrawUtil::getIndexFromName(references.at(0).getSubName());
int iSubelement1 = DrawUtil::getIndexFromName(references.at(1).getSubName());
int iSubelement2 = DrawUtil::getIndexFromName(references.at(2).getSubName());
if (refObject->isDerivedFrom(TechDraw::DrawViewPart::getClassTypeId())
if (refObject->isDerivedFrom<TechDraw::DrawViewPart>()
&& !references.at(0).getSubName().empty()) {
// this is a 2d object (a DVP + subelements)
TechDraw::VertexPtr vert0 = getViewPart()->getProjVertexByIndex(iSubelement0);