From df2e0ba8959610cfb9dbcac28b743591f2982aed Mon Sep 17 00:00:00 2001
From: Kacper Donat <kadet1090@gmail.com>
Date: Wed, 18 Dec 2024 21:00:00 +0100
Subject: [PATCH] Gui: Fix crash on qBounds for imperial units

---
 src/Gui/QuantitySpinBox.cpp |  2 +-
 src/Gui/TaskCSysDragger.ui  | 12 ------------
 2 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/src/Gui/QuantitySpinBox.cpp b/src/Gui/QuantitySpinBox.cpp
index 9e8acddaca..1ab6a81e84 100644
--- a/src/Gui/QuantitySpinBox.cpp
+++ b/src/Gui/QuantitySpinBox.cpp
@@ -449,7 +449,7 @@ void QuantitySpinBox::updateEdit(const QString& text)
 
     edit->setText(text);
 
-    cursor = qBound(0, cursor, edit->displayText().size() - d->unitStr.size());
+    cursor = qBound(0, cursor, qMax(0, edit->displayText().size() - d->unitStr.size()));
     if (selsize > 0) {
         edit->setSelection(0, cursor);
     }
diff --git a/src/Gui/TaskCSysDragger.ui b/src/Gui/TaskCSysDragger.ui
index a86539f01d..0371c734a7 100644
--- a/src/Gui/TaskCSysDragger.ui
+++ b/src/Gui/TaskCSysDragger.ui
@@ -126,16 +126,10 @@
          </property>
          <item row="4" column="1">
           <widget class="Gui::QuantitySpinBox" name="zPositionSpinBox">
-           <property name="unit" stdset="0">
-            <string>mm</string>
-           </property>
           </widget>
          </item>
          <item row="2" column="1">
           <widget class="Gui::QuantitySpinBox" name="xPositionSpinBox">
-           <property name="unit" stdset="0">
-            <string>mm</string>
-           </property>
           </widget>
          </item>
          <item row="2" column="0">
@@ -188,9 +182,6 @@
          </item>
          <item row="3" column="1">
           <widget class="Gui::QuantitySpinBox" name="yPositionSpinBox">
-           <property name="unit" stdset="0">
-            <string>mm</string>
-           </property>
           </widget>
          </item>
         </layout>
@@ -370,9 +361,6 @@
       </item>
       <item row="6" column="1">
        <widget class="Gui::QuantitySpinBox" name="translationIncrementSpinBox">
-        <property name="unit" stdset="0">
-         <string>mm</string>
-        </property>
         <property name="minimum">
          <double>0.000000000000000</double>
         </property>