kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

PVS: V773 A memory leak is possible

Browse Source
This commit is contained in:
wmayer
2019-02-17 18:40:06 +01:00
parent b2a5f47e44
commit e23db2e313
22 changed files with 74 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/Gui/ViewProviderBuilder.cpp
View File

@@ -101,21 +101,20 @@ ViewProviderColorBuilder::~ViewProviderColorBuilder()
{
}
void ViewProviderColorBuilder::buildNodes(const App::Property* prop, std::vector<SoNode*>&) const
void ViewProviderColorBuilder::buildNodes(const App::Property* prop, std::vector<SoNode*>& node) const
{
const App::PropertyColorList* color = static_cast<const App::PropertyColorList*>(prop);
const std::vector<App::Color>& val = color->getValues();
unsigned long i=0;
SoMaterial* material = new SoMaterial();
material->enableNotify(false);
material->diffuseColor.deleteValues(0);
material->diffuseColor.setNum(val.size());
SbColor* colors = material->diffuseColor.startEditing();
for (std::vector<App::Color>::const_iterator it = val.begin(); it != val.end(); ++it) {
material->diffuseColor.set1Value(i++, SbColor(it->r, it->g, it->b));
colors[i].setValue(it->r, it->g, it->b);
i++;
}
material->enableNotify(true);
material->touch();
material->diffuseColor.finishEditing();
node.push_back(material);
}