[Tools] Fix static analyis issues
This commit addresses issues identified by LGTM for the various independent (and mostly-independent) files in the Tools subdirectory. The vast majority of the issues are trivial, and are things like unused imports or catching BaseException. There was one true bug identified, a global variable being changed in a function where it was not marked global, but it only affected output quantity (the variable is named "VERBOSE"). A couple of other issues identified variables that appear to represent no-longer-existing options in the code. The options were left, but a deprecation printout replaces the variable in the event the option is provided.
This commit is contained in:
@@ -3,18 +3,15 @@
|
||||
# (c) 2012 Werner Mayer LGPL
|
||||
|
||||
import sys
|
||||
from os import chdir
|
||||
from os import path
|
||||
from tempfile import gettempdir
|
||||
|
||||
from bzrlib.transport import get_transport
|
||||
from bzrlib.branch import Branch
|
||||
from bzrlib.workingtree import WorkingTree
|
||||
|
||||
def runUpdate(filename):
|
||||
branch = "versioning.git"
|
||||
REMOTE_URL="bzr+ssh://bazaar.launchpad.net/~freecad-maintainers/freecad/%s" % (branch)
|
||||
PUSHTO_URL="bzr+ssh://bazaar.launchpad.net/~freecad-maintainers/freecad/%s" % (branch)
|
||||
LOCAL_BRANCH=path.join(gettempdir(),branch)
|
||||
|
||||
# Location of branch on Launchpad
|
||||
@@ -22,6 +19,7 @@ def runUpdate(filename):
|
||||
|
||||
# Location of branch on local system
|
||||
local_branch = remote_branch.bzrdir.sprout(LOCAL_BRANCH).open_branch()
|
||||
False if local_branch.__name__ else True # "Use" to silence analyzers, pending PEP 640 or similar
|
||||
|
||||
# Change a file in the local branch
|
||||
try:
|
||||
|
||||
Reference in New Issue
Block a user