From e2e0018df65f1ce073adc870189ce625c802018a Mon Sep 17 00:00:00 2001
From: mwganson <mwganson@gmail.com>
Date: Thu, 12 Mar 2020 16:17:36 -0500
Subject: [PATCH] [Spreadsheet] fix minor bug where failure to set alias
 message appears erroneously.  Fixes #4287

---
 src/Mod/Spreadsheet/Gui/SpreadsheetView.cpp | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/src/Mod/Spreadsheet/Gui/SpreadsheetView.cpp b/src/Mod/Spreadsheet/Gui/SpreadsheetView.cpp
index 8ac059fe46..49db8a42d6 100644
--- a/src/Mod/Spreadsheet/Gui/SpreadsheetView.cpp
+++ b/src/Mod/Spreadsheet/Gui/SpreadsheetView.cpp
@@ -341,7 +341,6 @@ void SheetView::editingFinished()
         bool aliasOkay = true;
 
         if (str.length()!= 0 && !sheet->isValidAlias(Base::Tools::toStdString(str))){
-            Base::Console().Error("Unable to set alias: %s\n", Base::Tools::toStdString(str).c_str());
             aliasOkay = false;
         }
 
@@ -349,8 +348,17 @@ void SheetView::editingFinished()
         ui->cells->model()->setData(i, QVariant(ui->cellContent->text()), Qt::EditRole);
 
         Cell * cell = sheet->getCell(CellAddress(i.row(), i.column()));
-        if (cell && aliasOkay){
-            cell->setAlias(str.toStdString());
+        if (cell){
+            if (!aliasOkay){
+                //do not show error message if failure to set new alias is because it is already the same string
+                std::string current_alias;
+                cell->getAlias(current_alias);
+                if (str != QString::fromUtf8(current_alias.c_str())){
+                    Base::Console().Error("Unable to set alias: %s\n", Base::Tools::toStdString(str).c_str());
+                }
+            } else {
+                cell->setAlias(str.toStdString());
+            }
         }
         ui->cells->setCurrentIndex(ui->cellContent->next());
         ui->cells->setFocus();