kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity

Spreadsheet: [skip ci] Fix several clazy issues:

Browse Source 
* Mixing iterators with const_iterators [-Wclazy-strict-iterators]
* Q_PROPERTY should have either NOTIFY or CONSTANT [-Wclazy-qproperty-without-notify]
* Missing reference in range-for with non trivial type [-Wclazy-range-loop-reference]
* Missing emit keyword on signal call SpreadsheetGui::SheetViewHeader::resizeFinished [-Wclazy-incorrect-emit]
* Missing emit keyword on signal call QAbstractItemModel::dataChanged [-Wclazy-incorrect-emit]
* c++11 range-loop might detach Qt container (QStringList) [-Wclazy-range-loop-detach]
This commit is contained in:
wmayer
2022-07-25 11:23:27 +02:00
parent 96ac382805
commit e2f1452cb8
5 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/Mod/Spreadsheet/Gui/SheetModel.cpp
View File

@@ -516,7 +516,7 @@ void SheetModel::cellUpdated(CellAddress address)
{
QModelIndex i = index(address.row(), address.col());
dataChanged(i, i);
Q_EMIT dataChanged(i, i);
}
void SheetModel::rangeUpdated(const Range &range)
@@ -524,7 +524,7 @@ void SheetModel::rangeUpdated(const Range &range)
QModelIndex i = index(range.from().row(), range.from().col());
QModelIndex j = index(range.to().row(), range.to().col());
dataChanged(i, j);
Q_EMIT dataChanged(i, j);
}
#include "moc_SheetModel.cpp"