From e392fc2f07cf657eb6762881695e5e9b84f226a2 Mon Sep 17 00:00:00 2001 From: wmayer Date: Wed, 13 Mar 2019 12:47:05 +0100 Subject: [PATCH] PVS: V522 There might be dereferencing of a potential null pointer --- src/Mod/Raytracing/Gui/Command.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/Mod/Raytracing/Gui/Command.cpp b/src/Mod/Raytracing/Gui/Command.cpp index d180ed2d05..0e79a70401 100644 --- a/src/Mod/Raytracing/Gui/Command.cpp +++ b/src/Mod/Raytracing/Gui/Command.cpp @@ -274,9 +274,11 @@ void CmdRaytracingWriteView::activated(int) Gui::ViewProvider* vp = getActiveGuiDocument()->getViewProvider(*it); if (vp && vp->isVisible()) { App::PropertyColor *pcColor = dynamic_cast(vp->getPropertyByName("ShapeColor")); - App::Color col = pcColor->getValue(); - doCommand(Doc,"content += Raytracing.getPartAsPovray('%s',App.activeDocument().%s.Shape,%f,%f,%f)", - (*it)->getNameInDocument(),(*it)->getNameInDocument(),col.r,col.g,col.b); + if (pcColor) { + App::Color col = pcColor->getValue(); + doCommand(Doc,"content += Raytracing.getPartAsPovray('%s',App.activeDocument().%s.Shape,%f,%f,%f)", + (*it)->getNameInDocument(),(*it)->getNameInDocument(),col.r,col.g,col.b); + } } } doCommand(Doc,"result = result.replace('//RaytracingContent',content)");